Skip to content

Commit ac975d2

Browse files
authored
[#132]: Proposed Fix - "Plot show Method Not Working on Windows 10" (#133)
* Changes to `show` method for Windows * `CHANGELOG.md` PR credits updated
1 parent 8903ff0 commit ac975d2

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a
55

66
## [0.8.4] - 2023-01-xx
77
### Fixed
8-
- [[#129](https://github.com/igiagkiozis/plotly/pull/129)] Fix issue for plots not showing in browser in Windows. Thanks to [@juanespj](https://github.com/juanespj) for the PR.
8+
- [[#129](https://github.com/igiagkiozis/plotly/pull/129)] Fix issue for plots not showing in browser in Windows. Thanks to [@juanespj](https://github.com/juanespj) and [@M-NK-Y](https://github.com/M-NK-Y) for the PRs.
99

1010
## [0.8.3] - 2022-11-04
1111
### Fixed

plotly/src/plot.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -471,9 +471,8 @@ impl Plot {
471471
fn show_with_default_app(temp_path: &str) {
472472
use std::process::Command;
473473
Command::new("cmd")
474-
.arg("/C")
475-
.arg(format!("start {}", temp_path))
476-
.output()
474+
.args(&["/C", "start", &format!(r#"{}"#, temp_path)])
475+
.spawn()
477476
.expect(DEFAULT_HTML_APP_NOT_FOUND);
478477
}
479478
}

0 commit comments

Comments
 (0)