Skip to content

Commit 4f54da9

Browse files
author
Marc-André Rivet
committed
Merge remote-tracking branch 'origin/dev'
2 parents 70a8c9e + 0d9b68c commit 4f54da9

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22
All notable changes to `dash` will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44

5+
## [1.13.2] - 2020-06-18
6+
### Fixed
7+
- [#1305](https://github.com/plotly/dash/issues/1305)
8+
- Fix regression that causes crash when `FLASK_ENV` is modified during app execution
9+
- Fix regression that caused tests using `_wait_for_callbacks` to fail
10+
511
## [1.13.1] - 2020-06-17
612

713
## [1.13.0] - 2020-06-17

dash/dash.py

-3
Original file line numberDiff line numberDiff line change
@@ -1612,7 +1612,4 @@ def verify_url_part(served_part, url_part, part_name):
16121612
" in production, use a production WSGI server like gunicorn instead.\n"
16131613
)
16141614

1615-
if not os.environ.get("FLASK_ENV"):
1616-
os.environ["FLASK_ENV"] = "development"
1617-
16181615
self.server.run(host=host, port=port, debug=debug, **flask_run_options)

dash/testing/dash_page.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def window_store(self):
7171
return self.driver.execute_script("return window.store")
7272

7373
def _wait_for_callbacks(self):
74-
return not self.window_store or self.redux_state_rqs
74+
return (not self.window_store) or self.redux_state_rqs == []
7575

7676
def get_local_storage(self, store_id="local"):
7777
return self.driver.execute_script(

dash/version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "1.13.1"
1+
__version__ = "1.13.2"

0 commit comments

Comments
 (0)