Feature request: add support for charset property

[Kydyralin]

Description

Add logic to map charset property to ESLint rule.

As of right now, there is no implementation for the rule that checks file encoding but after some discussion on the issue in the tslint-to-eslint-config repo, some may be added soon. So I decided to create the FR a bit ahead of time just to not forget it.

[platinumazure]

Hi @Kydyralin, thanks for the issue!

Would you please expand on your proposal? How do you envision charset in editor configs mapping to an ESLint rule?

Note that at this point, I'm not sure I want to add rules to this plugin itself: the plugin's current mission is to export an ESLint core rule configuration which enforces JavaScript according to the editor config settings. If a core ESLint rule is created for enforcing character sets somehow, then I am happy to add support for that rule.

[Kydyralin]

Hi!

Sorry for the late response. About your question: as mentioned in the description of this FR, we had a discussion on another repo about encoding tslint rule which, as of right now, has no implementation. Mr @criskrzysiu has answered that my issue created on the tslint-to-eslint-config repo probably isn't the best place for that and maybe I should create it here (since this repo suits well with charset config and encoding rule). Also, Mr @criskrzysiu said that maybe he could try to write the ESLint implementation for the rule so it would make sense to have FR to support it in this repo.

Hopefully, you get the idea of what we are trying to do. If not, feel free to ask anything and I'll try to explain it better.

Again, this FR is about adding support for the encoding rule only when the ESLint version will be implemented.

[platinumazure]

Sounds good @Kydyralin, that works for me.

If core ESLint declines a charset rule, let me know and we can consider implementing it here. Thanks!

[kbrilla]

Hi, I would suggest adding the rule here as it nicely fit here. Charset is usually configured in the .editorconfig file and adding it in second place like rule configuration could lead to errors. I think implementing it in one rule that enforce editorconfig settings would be much better solution. If You don’t have time to implement it Yourself I could try to create PR basing of the charset rule in tslint.

[platinumazure]

Hi @criskrzysiu, the purpose of this plugin is to automatically generate a configuration of core ESLint rules based on an .editorconfig file.

So, even if the rule is implemented in core ESLint, this plugin will allow you to set your charset only in .editorconfig without also having to set it explicitly in your ESLint config.

Let me know if there's anything I can clarify further.