fix: add side-effect: false

this might not help much, but by adding side-effect: false to a module, we are telling webpack that it can do more splitting and tree shaking optimizations

https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

Author: starpit

packages/core/package.json

@@ -27,6 +27,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "bin": {
     "kui": "bin/kui"
   },

packages/react/package.json

@@ -11,6 +11,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "repository": {
     "type": "git",
     "url": "git+https://github.com/IBM/kui.git"

plugins/plugin-bash-like/fs/package.json

@@ -22,6 +22,10 @@
   "main": "dist/index.js",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "publishConfig": {
     "access": "private"
   }

plugins/plugin-bash-like/package.json

@@ -23,6 +23,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@kui-shell/xterm-helpers": "2.0.0",
     "cookie": "0.5.0",

plugins/plugin-carbon-themes/package.json

@@ -23,6 +23,10 @@
   "main": "dist/index.js",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "publishConfig": {
     "access": "public"
   },

plugins/plugin-client-common/package.json

@@ -20,6 +20,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@fortawesome/fontawesome-free": "6.2.1",
     "@mdi/font": "7.1.96",

plugins/plugin-client-default/package.json

@@ -6,6 +6,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "license": "Apache-2.0",
   "author": "Mengting Yan",
   "homepage": "https://github.com/IBM/kui#readme",

plugins/plugin-core-support/package.json

@@ -23,6 +23,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@electron/remote": "2.0.9",
     "@supercharge/promise-pool": "2.3.2",

plugins/plugin-core-themes/package.json

@@ -23,6 +23,10 @@
   "main": "dist/index.js",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "publishConfig": {
     "access": "public"
   },

plugins/plugin-electron-components/package.json

@@ -20,6 +20,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@electron/remote": "2.0.9",
     "@patternfly/react-core": "^4.264.0",

plugins/plugin-git/package.json

@@ -23,6 +23,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "publishConfig": {
     "access": "public"
   },

plugins/plugin-kubectl-tray-menu/package.json

@@ -25,6 +25,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "debug": "4.3.4"
   },

plugins/plugin-kubectl/helm/package.json

@@ -27,6 +27,10 @@
   "main": "dist/index.js",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@kui-shell/core": "8.0.6",
     "@IBM/kui": "*",

plugins/plugin-kubectl/logs/package.json

@@ -26,6 +26,10 @@
   "main": "dist/index.js",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {},
   "krew": {
     "commandPrefix": "kubeui"

plugins/plugin-kubectl/oc/package.json

@@ -28,6 +28,10 @@
   "main": "dist/index.js",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@kui-shell/plugin-kubectl": "*"
   },

plugins/plugin-kubectl/odo/package.json

@@ -28,6 +28,10 @@
   "main": "dist/index.js",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@kui-shell/plugin-kubectl": "*"
   },

plugins/plugin-kubectl/package.json

@@ -27,6 +27,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@kui-shell/jsonpath": "1.1.1",
     "bytes-iec": "3.1.1",

plugins/plugin-patternfly4-themes/package.json

@@ -23,6 +23,10 @@
   "main": "dist/index.js",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "publishConfig": {
     "access": "public"
   },

plugins/plugin-s3/package.json

@@ -28,6 +28,10 @@
   "typedocMain": "src/index.ts",
   "module": "mdist/index.js",
   "types": "mdist/index.d.ts",
+  "sideEffects": [
+    "*.css",
+    "*.scss"
+  ],
   "dependencies": {
     "@patternfly/react-table": "^4.111.45",
     "common-path-prefix": "3.0.0",