-
Notifications
You must be signed in to change notification settings - Fork 458
Prepare DB for structured citations to come #11238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @asmecher, these are the minimal DB changes needed for 3.5.0, so that structured citations can come later at any point. |
Hmmm... @asmecher, do you think the hook renaming should also take place now, before 3.5.0: |
Yes, that's a good idea; it's unlikely to be used, but add the old one to the |
pkp/pkp-lib#11238 use publication citations data
pkp/pkp-lib#11238 use publication citations data
#11238 prepare DB for structured citations
pkp/pkp-lib#11238 prepare DB for structured citations
pkp/pkp-lib#11238 prepare DB for structured citations
pkp/pkp-lib#11238 prepare DB for structured citations
DB should be prepared so that the work on structured citation can come later, any time, and would not require a DB upgrade, so that structured citations can be merged without waiting for next major release where DB upgrades are allowed.
Structured citations require following DB changes:
Removing the column
setting_type
in the tablecitation_settings
, because citations are moved to the EntityDAO. This column will not be removed right now, but made nullable, so that old code and classes CitationDAO and Citation can still work. After structured citations are merged, this column can be removed in the next major release.Removing the setting
citationsRaw
from thepublication_settings
table. This will be done now, for 3.5.0. The raw citations for publication object will be constructed by concatenating the each/every single raw citation.Note: Multilingual citations would require more DB changes, e.g. moving the entries from the column
raw_citation
from the tablecitations
into thecitation_settings
table, but for now multiple citations will not be considered, thus these changes will be done once the work on multilingual citations starts/is done.PRs:
stable-3_5_0:
main:
pkp/crossrefReferenceLinking#31
pkp/medra#44
The text was updated successfully, but these errors were encountered: