Skip to content

Prepare DB for structured citations to come #11238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bozana opened this issue Apr 8, 2025 · 6 comments
Closed

Prepare DB for structured citations to come #11238

bozana opened this issue Apr 8, 2025 · 6 comments
Assignees
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Apr 8, 2025

DB should be prepared so that the work on structured citation can come later, any time, and would not require a DB upgrade, so that structured citations can be merged without waiting for next major release where DB upgrades are allowed.
Structured citations require following DB changes:
Removing the column setting_type in the table citation_settings, because citations are moved to the EntityDAO. This column will not be removed right now, but made nullable, so that old code and classes CitationDAO and Citation can still work. After structured citations are merged, this column can be removed in the next major release.
Removing the setting citationsRaw from the publication_settings table. This will be done now, for 3.5.0. The raw citations for publication object will be constructed by concatenating the each/every single raw citation.
Note: Multilingual citations would require more DB changes, e.g. moving the entries from the column raw_citation from the table citations into the citation_settings table, but for now multiple citations will not be considered, thus these changes will be done once the work on multilingual citations starts/is done.

PRs:
stable-3_5_0:

main:

pkp/crossrefReferenceLinking#31
pkp/medra#44

@bozana bozana added this to the 3.5 Internal milestone Apr 8, 2025
@bozana bozana self-assigned this Apr 8, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 8, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 8, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 8, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 8, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 8, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 10, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 10, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 10, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 10, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 10, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 10, 2025
bozana added a commit to bozana/omp that referenced this issue Apr 10, 2025
bozana added a commit to bozana/omp that referenced this issue Apr 10, 2025
bozana added a commit to bozana/ops that referenced this issue Apr 10, 2025
bozana added a commit to bozana/ops that referenced this issue Apr 10, 2025
@bozana
Copy link
Collaborator Author

bozana commented Apr 10, 2025

Hi @asmecher, these are the minimal DB changes needed for 3.5.0, so that structured citations can come later at any point.
Could you please review the PRs?
Thanks a lot!

@bozana
Copy link
Collaborator Author

bozana commented Apr 10, 2025

Hmmm... @asmecher, do you think the hook renaming should also take place now, before 3.5.0:
CitationDAO::afterImportCitations -> Citation::importCitations::after ?

@asmecher
Copy link
Member

Hmmm... @asmecher, do you think the hook renaming should also take place now, before 3.5.0:

Yes, that's a good idea; it's unlikely to be used, but add the old one to the Hook::addUnsupportedHooks list in lib/pkp/classes/core/PKPApplication.php; at the same time, make the switch from Hook::run to Hook::call per these conventions. (All new hooks should use Hook::run, which isn't 100% backwards compatible.)

bozana added a commit to pkp/jatsTemplate that referenced this issue Apr 15, 2025
bozana added a commit to bozana/googleScholar that referenced this issue Apr 15, 2025
bozana added a commit to pkp/googleScholar that referenced this issue Apr 15, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 15, 2025
bozana added a commit to bozana/omp that referenced this issue Apr 15, 2025
bozana added a commit to bozana/omp that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ops that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ops that referenced this issue Apr 15, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ops that referenced this issue Apr 15, 2025
bozana added a commit to bozana/omp that referenced this issue Apr 15, 2025
bozana added a commit to bozana/omp that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ojs that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ops that referenced this issue Apr 15, 2025
bozana added a commit to bozana/ops that referenced this issue Apr 15, 2025
bozana added a commit that referenced this issue Apr 15, 2025
#11238 prepare DB for structured citations
bozana added a commit to pkp/omp that referenced this issue Apr 15, 2025
pkp/pkp-lib#11238 prepare DB for structured citations
bozana added a commit to pkp/ops that referenced this issue Apr 15, 2025
pkp/pkp-lib#11238 prepare DB for structured citations
bozana added a commit to pkp/ojs that referenced this issue Apr 15, 2025
pkp/pkp-lib#11238 prepare DB for structured citations
@bozana bozana closed this as completed Apr 15, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Metadata and Distribution Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants