Skip to content

[Submission Workflow] | Add Reviewer - Select Reviewer, Add reviewer form has some unrendered variable #11190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Tribunal33 opened this issue Mar 27, 2025 · 5 comments
Assignees
Labels
Bug:0:Trivial A bug mainly used for UI bugs that do not affect common functionality but break user experience.
Milestone

Comments

@Tribunal33
Copy link
Contributor

Tribunal33 commented Mar 27, 2025

Valid Title

  • I have updated the title to accurately reflect the bug description

Description

Noticing that adding a reviewer form has some extra variable that is not rendered in 3.5 that isn't showing up for 3.4. Also seen when editing an existing reviewer

Steps to Reproduce

  1. Login with User/Role JM or JE with access to add a reviewer
  2. Navigate to submission in review stage
  3. Click on Add Reviewers Button
  4. Select Reviewer button from a reviewer in the list
  5. Scroll to Important Dates section

Expected Result

Should not have underndered variable displayed.

Image

Actual Result

Unrendered variable is displayed ##editor.review.importantDates.notice##

Environment Details

No response

Application Version

OJS 3.5 RC2

Logs

No response

Additional Information

No response

PRs

main

pkp-lib --> #11201
omp --> pkp/omp#1924 [TEST ONLY]

Stable-3.5.0

pkp-lib --> #11202
omp --> pkp/omp#1925 [TEST ONLY]

@Tribunal33 Tribunal33 added the Bug:0:Trivial A bug mainly used for UI bugs that do not affect common functionality but break user experience. label Mar 27, 2025
@Tribunal33 Tribunal33 added this to the 3.5 Internal milestone Mar 27, 2025
@Tribunal33 Tribunal33 self-assigned this Mar 27, 2025
@jardakotesovec
Copy link
Contributor

@touhidurabir Can you have a look? Looks like its coming from change in #5885 . Seems like missing translation.

@touhidurabir
Copy link
Member

@jardakotesovec Yes, it was a changes applied as part of #5885 ( see here ) but seems to be mistakenly removed at c027f93#diff-cf8af2097debc333109cce8a380c21c574d6f6330cb3b5d6443a31f6e9d12b49 as part of #9893 . My guess it's probably happened at rebase time .

@touhidurabir
Copy link
Member

@jardakotesovec can you please merge the PRs at #11190 (comment) , only the pkp-lib commit as this is only for missing translation keys which remove accidentally , see this comment

@jardakotesovec
Copy link
Contributor

@touhidurabir @Tribunal33 Merged, sorry for delay.

@Tribunal33
Copy link
Contributor Author

This has passed QA on main and stable 3.5.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:0:Trivial A bug mainly used for UI bugs that do not affect common functionality but break user experience.
Projects
None yet
Development

No branches or pull requests

3 participants