-
Notifications
You must be signed in to change notification settings - Fork 459
[Submission Workflow] | Add Reviewer - Select Reviewer, Add reviewer form has some unrendered variable #11190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@touhidurabir Can you have a look? Looks like its coming from change in #5885 . Seems like missing translation. |
@jardakotesovec Yes, it was a changes applied as part of #5885 ( see here ) but seems to be mistakenly removed at c027f93#diff-cf8af2097debc333109cce8a380c21c574d6f6330cb3b5d6443a31f6e9d12b49 as part of #9893 . My guess it's probably happened at rebase time . |
@jardakotesovec can you please merge the PRs at #11190 (comment) , only the |
@touhidurabir @Tribunal33 Merged, sorry for delay. |
Valid Title
Description
Noticing that adding a reviewer form has some extra variable that is not rendered in 3.5 that isn't showing up for 3.4. Also seen when editing an existing reviewer
Steps to Reproduce
Expected Result
Should not have underndered variable displayed.
Actual Result
Unrendered variable is displayed ##editor.review.importantDates.notice##
Environment Details
No response
Application Version
OJS 3.5 RC2
Logs
No response
Additional Information
No response
PRs
main
pkp-lib --> #11201
omp --> pkp/omp#1924 [TEST ONLY]
Stable-3.5.0
pkp-lib --> #11202
omp --> pkp/omp#1925 [TEST ONLY]
The text was updated successfully, but these errors were encountered: