Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be support for Spaces? #547

Open
Domcsore opened this issue Jan 6, 2025 · 2 comments
Open

Will there be support for Spaces? #547

Domcsore opened this issue Jan 6, 2025 · 2 comments

Comments

@Domcsore
Copy link

Domcsore commented Jan 6, 2025

I can see Digital Ocean offer Spaces but it doesn't look like this wrapper currently supports them. Is there an intention to support Spaces in the future? Or if not would you be open to contribution to support spaces?

Thanks

@pjpimentel pjpimentel self-assigned this Jan 7, 2025
@pjpimentel
Copy link
Owner

pjpimentel commented Jan 7, 2025

hello @Domcsore!

in the past i have thought about it but my conclusion was: is better to use and enjoy the aws s3 package compatibility rather than create a new one that "does the same thing".

i think the conclusion stll makes sense... don't?

and yes: i am open to contribution but i admit i would be more confortable to accept the "spaces module" if more people show interest about it

let keep this issue open, maybe someone else read this and react to this 😄

@Domcsore
Copy link
Author

After Digital Oceans incident report on the AWS SDK, I feel like a dedicated solution might be worth considering. We're at the whim of AWS not changing their implementation.

I did, in fact, agree that it didn't make much sense to make a solution if one already existed and, here's the key, worked.

It may be best to give DI a chance to see if this can be prevented in the future before starting any work on this either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants