Skip to content

Commit 9216e26

Browse files
committed
Remove the term "wrapper"
1 parent 7b8726e commit 9216e26

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

webextensions/sidebar/pinned-tabs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export function reposition(options = {}) {
123123
//log('=> new row');
124124
}
125125
}
126-
SidebarTabs.pinnedContainerWrapper.classList.toggle('overflow', contentsHeight > mAreaHeight);
126+
SidebarTabs.pinnedContainer.classList.toggle('overflow', contentsHeight > mAreaHeight);
127127
}
128128

129129
export function reserveToReposition(options = {}) {

webextensions/sidebar/sidebar-tabs.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ let mPromisedInitialized = new Promise((resolve, _reject) => {
4545
mPromisedInitializedResolver = resolve;
4646
});
4747

48-
export const pinnedContainerWrapper = document.querySelector('#pinned-tabs-container');
49-
export const noramlContainerWrapper = document.querySelector('#normal-tabs-container');
48+
export const pinnedContainer = document.querySelector('#pinned-tabs-container');
49+
export const normalContainer = document.querySelector('#normal-tabs-container');
5050

5151
export const onPinnedTabsChanged = new EventListenerManager();
5252
export const onNormalTabsChanged = new EventListenerManager();
@@ -393,7 +393,7 @@ Window.onInitialized.addListener(win => {
393393
let pinnedContainer = document.getElementById(`window-${windowId}-pinned`);
394394
if (!pinnedContainer) {
395395
pinnedContainer = document.createElement('ul');
396-
pinnedContainerWrapper.appendChild(pinnedContainer);
396+
pinnedContainer.appendChild(pinnedContainer);
397397
}
398398
pinnedContainer.dataset.windowId = windowId;
399399
pinnedContainer.setAttribute('id', `window-${windowId}-pinned`);
@@ -411,8 +411,8 @@ Window.onInitialized.addListener(win => {
411411
wrapper.classList.add('virtual-scroll-container');
412412
wrapper.classList.add('vbox');
413413
wrapper.appendChild(container);
414-
noramlContainerWrapper.appendChild(wrapper);
415-
const spacer = noramlContainerWrapper.appendChild(document.createElement('div'));
414+
normalContainer.appendChild(wrapper);
415+
const spacer = normalContainer.appendChild(document.createElement('div'));
416416
spacer.classList.add('vbox');
417417
spacer.classList.add(Constants.kTABBAR_SPACER);
418418
}

webextensions/sidebar/sidebar.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -524,9 +524,9 @@ function updateContextualIdentitiesSelector() {
524524
export async function rebuildAll(importedTabs) {
525525
MetricsData.add('rebuildAll: start');
526526
const range = document.createRange();
527-
range.selectNodeContents(SidebarTabs.pinnedContainerWrapper);
527+
range.selectNodeContents(SidebarTabs.pinnedContainer);
528528
range.deleteContents();
529-
range.selectNodeContents(SidebarTabs.noramlContainerWrapper);
529+
range.selectNodeContents(SidebarTabs.normalContainer);
530530
range.deleteContents();
531531
range.detach();
532532

@@ -760,7 +760,7 @@ function updateTabbarLayout({ reason, reasons, timeout, justNow } = {}) {
760760
if (!(reasons & Constants.kTABBAR_UPDATE_REASON_VIRTUAL_SCROLL_VIEWPORT_UPDATE))
761761
Scroll.reserveToRenderVirtualScrollViewport();
762762

763-
if (SidebarTabs.noramlContainerWrapper.classList.contains(Constants.kTABBAR_STATE_OVERFLOW)) {
763+
if (SidebarTabs.normalContainer.classList.contains(Constants.kTABBAR_STATE_OVERFLOW)) {
764764
window.requestAnimationFrame(() => {
765765
// scrollbar is shown only when hover on Windows 11, Linux, and macOS.
766766
const virtualScrollContainer = document.querySelector('.virtual-scroll-container');
@@ -778,7 +778,7 @@ function updateTabbarLayout({ reason, reasons, timeout, justNow } = {}) {
778778
}
779779
updateTabbarLayout.lastUpdateReasons = 0;
780780

781-
SidebarTabs.noramlContainerWrapper.addEventListener('overflow', event => {
781+
SidebarTabs.normalContainer.addEventListener('overflow', event => {
782782
if (event.target != event.currentTarget)
783783
return;
784784

@@ -814,7 +814,7 @@ SidebarTabs.noramlContainerWrapper.addEventListener('overflow', event => {
814814
});
815815
});
816816

817-
SidebarTabs.noramlContainerWrapper.addEventListener('underflow', event => {
817+
SidebarTabs.normalContainer.addEventListener('underflow', event => {
818818
if (event.target != event.currentTarget)
819819
return;
820820

0 commit comments

Comments
 (0)