Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batches don't work well with ActiveJobs #2

Open
pirj opened this issue Feb 19, 2025 · 0 comments
Open

batches don't work well with ActiveJobs #2

pirj opened this issue Feb 19, 2025 · 0 comments

Comments

@pirj
Copy link
Owner

pirj commented Feb 19, 2025

From toptal#9

Avoid using self-scheduling jobs for long-running jobs. Prefer using Sidekiq Batches to split the workload.

is misleading, because:

Batches break if you use Active Job’s retry_on feature. Since that is quite common, I recommend against using AJ for batches.

toptal#9 (comment)

This guideline needs to be adjusted to avoid those who do use Active Job on top of Sidekiq from using Sidekiq Batches.

Q: How does maintenance_tasks do batches with Active Job?
Do they use their job-iteration underneath?
Would it be reasonable to recommend it when ActiveJob is used on top of Sidekiq?
Sidekiq batches still make sense when using Sidekiq directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant