Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush semantics are unclear #56

Open
ronag opened this issue Dec 10, 2021 · 1 comment
Open

flush semantics are unclear #56

ronag opened this issue Dec 10, 2021 · 1 comment

Comments

@ronag
Copy link
Contributor

ronag commented Dec 10, 2021

The semantics of flush is a little unclear to me, i.e. when I call flush(cb) I'd expect that all data that I have write(chunk) would be flushed when cb is invoked. However, unlike flushSync this is not the case. flush doesn't actually flush the buffer to the worker, it just waits for whatever already has been flushed to worker is done.

@ronag
Copy link
Contributor Author

ronag commented Dec 10, 2021

I notice there is actually a todo for this already:

  // TODO write all .buf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant