Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: set block size for pebble SSTWriter #59010

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lightning: set block size for pebble SSTWriter #59010

wants to merge 2 commits into from
+4 −0

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Jan 17, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #59014

Problem Summary:

For local sort using pebbles, it seems like the default block size (16K) is not set when writing SST files.

tidb/pkg/lightning/config/config.go

Line 99 in 36e8e34

DefaultBlockSize = 16 * units.KiB

What changed and how does it work?

Set BlockSize to rc.cfg.TikvImporter.BlockSize.

Test was done on my local machine, which using lightning to import a single csv with 2 million rows and 250 columns.

In order to make a relatively fair comparison, I cleared the data and restart the cluster using tiup before each test.

Before:

image

After:

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 17, 2025

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.6790%. Comparing base (36e8e34) to head (a891740).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59010        +/-   ##
================================================
+ Coverage   73.0285%   73.6790%   +0.6505%     
================================================
  Files          1684       1714        +30     
  Lines        465663     473741      +8078     
================================================
+ Hits         340067     349048      +8981     
+ Misses       104691     103071      -1620     
- Partials      20905      21622       +717
Flag Coverage Δ
integration 45.6021% <100.0000%> (?)
unit 72.2119% <100.0000%> (+<0.0001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.2406% <ø> (+0.0086%) ⬆️

@joechenrh joechenrh changed the title lightning: set block size for pebble SST in local sort lightning: set block size for pebble SSTWriter Jan 17, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning doesn't use block size in configuration when opening SSTWriter
1 participant
@joechenrh