You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Open file with fs.open and use fs.fstat and fs.createReadStream(null, { fd }) otherwise we might have a race where the file at the specified path is replaced in the time between fs.stat and fs.createReadStream and wrong header data is provided.
The text was updated successfully, but these errors were encountered:
Have you actually run into this issue? The window of time for something like that to occur must be a few milliseconds at most. Switching to the method you suggest would add significant complexity to error handling because Node will not automatically close the file descriptor if an error occurs and failing to close the file descriptor will eventually lead to an EMFILE: too many open files error being thrown.
jcready
added a commit
to jcready/send
that referenced
this issue
Dec 17, 2016
Open file with
fs.open
and usefs.fstat
andfs.createReadStream(null, { fd })
otherwise we might have a race where the file at the specified path is replaced in the time betweenfs.stat
andfs.createReadStream
and wrong header data is provided.The text was updated successfully, but these errors were encountered: