Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async enhancement. #48

Merged
merged 1 commit into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,56 +19,25 @@ class AsyncRequestExecutor<Response, ResponseContent> {
this.responseContentExtractor = responseContentExtractor;
}

AsyncResponseHandling onResponse(Consumer<ResponseContent> responseHandler) {
return new AsyncResponseHandling() {

void onResponse(Consumer<ResponseContent> responseHandler, Consumer<Throwable> errorHandler) {
call.enqueue(new retrofit2.Callback<Response>() {
@Override
public ErrorHandling onError(Consumer<Throwable> errorHandler) {
return new ErrorHandling() {

@Override
public ResponseHandle execute() {
try {
retrofit2.Response<Response> retrofitResponse = call.execute();
if (retrofitResponse.isSuccessful()) {
Response response = retrofitResponse.body();
ResponseContent responseContent = responseContentExtractor.apply(response);
responseHandler.accept(responseContent);
}
else {
errorHandler.accept(toException(retrofitResponse));
}
}
catch (IOException e) {
errorHandler.accept(e);
}
return new ResponseHandle();
}
};
public void onResponse(Call<Response> call, retrofit2.Response<Response> response) {
if (response.isSuccessful()) {
responseHandler.accept(responseContentExtractor.apply(response.body()));
} else {
try {
errorHandler.accept(toException(response));
} catch (IOException e) {
throw new RuntimeException(e);
}
}
}

@Override
public ErrorHandling ignoreErrors() {
return new ErrorHandling() {

@Override
public ResponseHandle execute() {
try {
retrofit2.Response<Response> retrofitResponse = call.execute();
if (retrofitResponse.isSuccessful()) {
Response response = retrofitResponse.body();
ResponseContent responseContent = responseContentExtractor.apply(response);
responseHandler.accept(responseContent);
}
}
catch (IOException e) {
// intentionally ignoring, because user called ignoreErrors()
}
return new ResponseHandle();
}
};
public void onFailure(Call<Response> call, Throwable t) {
errorHandler.accept(t);
}
};
});
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ public ResponseContent execute() {
}

@Override
public AsyncResponseHandling onResponse(Consumer<ResponseContent> responseHandler) {
public void onResponse(Consumer<ResponseContent> responseHandler,Consumer<Throwable> errorHandler) {

return new AsyncRequestExecutor<>(call, responseContentExtractor).onResponse(responseHandler);
new AsyncRequestExecutor<>(call, responseContentExtractor).onResponse(responseHandler,errorHandler);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ public interface SyncOrAsync<ResponseContent> {

ResponseContent execute();

AsyncResponseHandling onResponse(Consumer<ResponseContent> responseHandler);
void onResponse(Consumer<ResponseContent> responseHandler,Consumer<Throwable> errorHandler);

}