Skip to content

Commit 0ccccb1

Browse files
committed
selectSingle() is being deprecated
1 parent f94d246 commit 0ccccb1

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
],
88
"require": {
99
"php": "^7.2 || ^8.0",
10-
"phpstan/phpstan": "^1.12"
10+
"phpstan/phpstan": "^1.12.5"
1111
},
1212
"require-dev": {
1313
"php-parallel-lint/php-parallel-lint": "^1.2",

src/Rules/Deprecations/TypeHintDeprecatedInClassMethodSignatureRule.php

+2-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use PhpParser\Node;
66
use PHPStan\Analyser\Scope;
77
use PHPStan\Node\InClassMethodNode;
8-
use PHPStan\Reflection\ParametersAcceptorSelector;
98
use PHPStan\Rules\Rule;
109
use PHPStan\Rules\RuleErrorBuilder;
1110
use function sprintf;
@@ -41,10 +40,9 @@ public function processNode(Node $node, Scope $scope): array
4140
}
4241

4342
$method = $node->getMethodReflection();
44-
$methodSignature = ParametersAcceptorSelector::selectSingle($method->getVariants());
4543

4644
$errors = [];
47-
foreach ($methodSignature->getParameters() as $parameter) {
45+
foreach ($method->getParameters() as $parameter) {
4846
$deprecatedClasses = $this->deprecatedClassHelper->filterDeprecatedClasses($parameter->getType()->getReferencedClasses());
4947
foreach ($deprecatedClasses as $deprecatedClass) {
5048
if ($method->getDeclaringClass()->isAnonymous()) {
@@ -70,7 +68,7 @@ public function processNode(Node $node, Scope $scope): array
7068
}
7169
}
7270

73-
$deprecatedClasses = $this->deprecatedClassHelper->filterDeprecatedClasses($methodSignature->getReturnType()->getReferencedClasses());
71+
$deprecatedClasses = $this->deprecatedClassHelper->filterDeprecatedClasses($method->getReturnType()->getReferencedClasses());
7472
foreach ($deprecatedClasses as $deprecatedClass) {
7573
if ($method->getDeclaringClass()->isAnonymous()) {
7674
$errors[] = RuleErrorBuilder::message(sprintf(

src/Rules/Deprecations/TypeHintDeprecatedInFunctionSignatureRule.php

+2-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use PhpParser\Node;
66
use PHPStan\Analyser\Scope;
77
use PHPStan\Node\InFunctionNode;
8-
use PHPStan\Reflection\ParametersAcceptorSelector;
98
use PHPStan\Rules\Rule;
109
use PHPStan\Rules\RuleErrorBuilder;
1110
use PHPStan\ShouldNotHappenException;
@@ -45,10 +44,9 @@ public function processNode(Node $node, Scope $scope): array
4544
if ($function === null) {
4645
throw new ShouldNotHappenException();
4746
}
48-
$functionSignature = ParametersAcceptorSelector::selectSingle($function->getVariants());
4947

5048
$errors = [];
51-
foreach ($functionSignature->getParameters() as $parameter) {
49+
foreach ($function->getParameters() as $parameter) {
5250
$deprecatedClasses = $this->deprecatedClassHelper->filterDeprecatedClasses($parameter->getType()->getReferencedClasses());
5351
foreach ($deprecatedClasses as $deprecatedClass) {
5452
$errors[] = RuleErrorBuilder::message(sprintf(
@@ -62,7 +60,7 @@ public function processNode(Node $node, Scope $scope): array
6260
}
6361
}
6462

65-
$deprecatedClasses = $this->deprecatedClassHelper->filterDeprecatedClasses($functionSignature->getReturnType()->getReferencedClasses());
63+
$deprecatedClasses = $this->deprecatedClassHelper->filterDeprecatedClasses($function->getReturnType()->getReferencedClasses());
6664
foreach ($deprecatedClasses as $deprecatedClass) {
6765
$errors[] = RuleErrorBuilder::message(sprintf(
6866
'Return type of function %s() has typehint with deprecated %s %s%s',

0 commit comments

Comments
 (0)