ext/date: Change return type of check_id_allowed from int to bool

Girgias · Girgias · commit 043b66c3a9cb · 2025-03-13T20:16:48.000Z
diff --git a/ext/date/php_date.c b/ext/date/php_date.c
@@ -5289,7 +5289,7 @@ PHP_METHOD(DatePeriod, getIterator)
 	zend_create_internal_iterator_zval(return_value, ZEND_THIS);
 }
 
-static int check_id_allowed(const char *id, zend_long what) /* {{{ */
+static bool check_id_allowed(const char *id, zend_long what) /* {{{ */
 {
 	if ((what & PHP_DATE_TIMEZONE_GROUP_AFRICA)     && strncasecmp(id, "Africa/",      7) == 0) return 1;
 	if ((what & PHP_DATE_TIMEZONE_GROUP_AMERICA)    && strncasecmp(id, "America/",     8) == 0) return 1;

Original file line number	Diff line number	Diff line change
`@@ -5289,7 +5289,7 @@ PHP_METHOD(DatePeriod, getIterator)`
`5289`	`5289`	`zend_create_internal_iterator_zval(return_value, ZEND_THIS);`
`5290`	`5290`	`}`
`5291`	`5291`
`5292`		`-static int check_id_allowed(const char id, zend_long what) / {{{ */`
	`5292`	`+static bool check_id_allowed(const char id, zend_long what) / {{{ */`
`5293`	`5293`	`{`
`5294`	`5294`	`if ((what & PHP_DATE_TIMEZONE_GROUP_AFRICA) && strncasecmp(id, "Africa/", 7) == 0) return 1;`
`5295`	`5295`	`if ((what & PHP_DATE_TIMEZONE_GROUP_AMERICA) && strncasecmp(id, "America/", 8) == 0) return 1;`