-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto config breaks if project contains period .
#367
Comments
docker-compose project names cannot contain a dot. DDEV removes the dot for compose project names. So COMPOSE_PROJECT_NAME must not have a dot and should be lower case. This was all discussed in for about 2 years. I guess maybe we have to look again @nico-loeber @AkibaAT ? |
Thanks for the speedy reply! And nice to meet you. My understanding is that the referenced issue is about removing the envvar. From what I've read on some IntelliJ tickets, it's still needed. The fix for me was to change the value of the envvar not remove it. I'll try removing it though and see if that also works. |
We decided that removing COMPOSE_PROJECT_NAME broke PhpStorm, because PhpStorm used it for an additional reason. But I thought we had solved the "dot" problem elsewhere in PhpStorm. |
I took a look at this issue together with @edditor. The COMPOSE_PROJECT_NAME seems not to strip any dots or have any other sanitization. See the DockerComposeCredentialProviderImpl.java#L30. This seems not to cause any problems during the project setup, issues appear if you try to execute something inside the container via PHPStorm (e.g. PHPUnit). I guess it should not be to much of a problem to update the |
Here's a test build with added period removal: ddev-intellij-plugin-0.0.1-dev.zip Closed my PR after realizing there already was one doing exactly the same thing right above. |
Fix COMPOSE_PROJECT_NAME period issue #367
Is there an existing issue for this?
Are you sure that this bug is related to this DDEV Integration Plugin?
Enter your error report ID (If available)
No response
Describe the bug
I have a project called
gpo.ca
(the URL of the site I'm working on) in ddev is fine with me calling it that and sanitizes the name where necessary.I installed this plugin to use the ddev interpreter in phpstorm. The auto load was awesome but appears not to have done the same sanitization.
I was receiving an error
Failed to start docker-compose service, start it in a command line and retry
and found that the issue was withCOMPOSE_PROJECT_NAME=ddev-secure.gpo.ca
.In the
./.ddev/.ddev-docker-compose-full.yaml
file the project name isddev-securegpoca
Changing
COMPOSE_PROJECT_NAME
toddev-securegpoca
fixed my issue.Steps to reproduce
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: