fix: Rename create_serving_url into inject_serving_url (viur-framework#1241)

Author: phorward

src/viur/core/modules/file.py

@@ -405,7 +405,7 @@ def refresh(cls, skelValues):
                     skelValues["downloadUrl"] = importData
                 skelValues["pendingparententry"] = False
 
-        conf.main_app.file.create_serving_url(skelValues)
+        conf.main_app.file.inject_serving_url(skelValues)
 
 
 class FileNodeSkel(TreeSkel):
@@ -508,7 +508,7 @@ def create_internal_serving_url(
         This is needed to hide requests to Google as they are internally be routed, and can be the result of a
         legal requirement like GDPR.
 
-        :param serving_url: Is the original serving URL as generated from create_serving_url()
+        :param serving_url: Is the original serving URL as generated from inject_serving_url()
         :param size: Optional size setting
         :param filename: Optonal filename setting
         :param options: Additional options parameter-pass through to /file/serve
@@ -1139,8 +1139,7 @@ def add(self, skelType: SkelType, node: db.Key | int | str | None = None, *args,
             skel["weak"] = rootNode is None
             skel["crc32c_checksum"] = base64.b64decode(blob.crc32c).hex()
             skel["md5_checksum"] = base64.b64decode(blob.md5_hash).hex()
-
-            skel = self.create_serving_url(skel)
+            self.inject_serving_url(skel)
 
             skel.toDB()
 
@@ -1172,7 +1171,7 @@ def onEdit(self, skelType: SkelType, skel: SkeletonInstance):
         bucket.copy_blob(old_blob, bucket, new_path, if_generation_match=0)
         bucket.delete_blob(old_path)
 
-        self.create_serving_url(skel)
+        self.inject_serving_url(skel)
 
     def mark_for_deletion(self, dlkey: str) -> None:
         """
@@ -1196,9 +1195,8 @@ def mark_for_deletion(self, dlkey: str) -> None:
 
         db.Put(fileObj)
 
-    def create_serving_url(self, skel: SkeletonInstance) -> SkeletonInstance:
-        """ Create Serving url for public image files
-        """
+    def inject_serving_url(self, skel: SkeletonInstance) -> None:
+        """Inject the serving url for public image files into a FileSkel"""
         # try to create a servingurl for images
         if not conf.instance.is_dev_server and skel["public"] and skel["mimetype"] \
                 and skel["mimetype"].startswith("image/") and not skel["serving_url"]:
@@ -1214,8 +1212,6 @@ def create_serving_url(self, skel: SkeletonInstance) -> SkeletonInstance:
                 logging.warning("Error while creating serving url")
                 logging.exception(e)
 
-        return skel
-
 
 @PeriodicTask(interval=datetime.timedelta(hours=4))
 def startCheckForUnreferencedBlobs():