Only use UTF-8 without BOM (#299)

Author: Corniel

.editorconfig

@@ -6,6 +6,7 @@ root = true
 # Don't use tabs for indentation.
 [*]
 indent_style = space
+charset = utf-8
 # (Please don't specify an indent_size here; that has too many unintended consequences.)
 
 # Code files

nuget.config

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <configuration>
     <packageSources>
         <clear />

src/Buildalyzer.Logger/Buildalyzer.Logger.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>

src/Buildalyzer.Logger/BuildalyzerLogger.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Linq;
 using Microsoft.Build.Framework;
 using MsBuildPipeLogger;

src/Buildalyzer.Workspaces/AnalyzerManagerExtensions.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.Build.Construction;

src/Buildalyzer.Workspaces/AnalyzerResultExtensions.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;

src/Buildalyzer.Workspaces/Buildalyzer.Workspaces.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFrameworks>net6.0;net8.0</TargetFrameworks>

src/Buildalyzer.Workspaces/ProjectAnalyzerExtensions.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Linq;
 using Microsoft.CodeAnalysis;
 

src/Buildalyzer/AnalyzerManager.cs

@@ -1,4 +1,4 @@
-extern alias StructuredLogger;
+extern alias StructuredLogger;
 using System.Collections.Concurrent;
 using System.IO;
 using Buildalyzer.Logging;

src/Buildalyzer/AnalyzerManagerOptions.cs

@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 using Buildalyzer.Logging;
 using Microsoft.Build.Construction;
 using Microsoft.Extensions.Logging;

src/Buildalyzer/AnalyzerResults.cs

@@ -1,4 +1,4 @@
-using System.Collections.Concurrent;
+using System.Collections.Concurrent;
 
 namespace Buildalyzer;
 

src/Buildalyzer/BuildEventArgsCollector.cs

@@ -1,4 +1,4 @@
-using System.Collections.Concurrent;
+using System.Collections.Concurrent;
 using Microsoft.Build.Framework;
 using Microsoft.Build.Logging;
 

src/Buildalyzer/Compiler/CSharpCompilerCommand.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using Microsoft.CodeAnalysis.CSharp;
 

src/Buildalyzer/Compiler/Compiler.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System.IO;
 using Buildalyzer.IO;

src/Buildalyzer/Compiler/CompilerCommand.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System.IO;
 using Buildalyzer.IO;

src/Buildalyzer/Compiler/CompilerItems.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using Microsoft.Build.Framework;
 

src/Buildalyzer/Compiler/CompilerItemsCollection.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using Microsoft.Build.Framework;
 

src/Buildalyzer/Compiler/CompilerLanguage.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 /// <summary>The compiler language.</summary>
 public enum CompilerLanguage

src/Buildalyzer/Compiler/CompilerProperties.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 namespace Buildalyzer;
 

src/Buildalyzer/Compiler/CompilerProperty.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 namespace Buildalyzer;
 

src/Buildalyzer/Compiler/FSharpCommandLineParser.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System;
 

src/Buildalyzer/Compiler/FSharpCompilerCommand.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 public sealed record FSharpCompilerCommand : CompilerCommand
 {

src/Buildalyzer/Compiler/RoslynBasedCompilerCommand.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using Microsoft.CodeAnalysis;
 

src/Buildalyzer/Compiler/RoslynCommandLineParser.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System;
 using Microsoft.CodeAnalysis;

src/Buildalyzer/Compiler/VisualBasicCompilerCommand.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using Microsoft.CodeAnalysis.VisualBasic;
 

src/Buildalyzer/Construction/IPackageReference.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer.Construction;
+namespace Buildalyzer.Construction;
 
 public interface IPackageReference
 {

src/Buildalyzer/Construction/IProjectFile.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer.Construction;
+namespace Buildalyzer.Construction;
 
 public interface IProjectFile
 {

src/Buildalyzer/Construction/PackageReference.cs

@@ -1,4 +1,4 @@
-using System.Xml.Linq;
+using System.Xml.Linq;
 
 namespace Buildalyzer.Construction;
 

src/Buildalyzer/Construction/ProjectFile.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.IO;
 using System.Xml.Linq;
 

src/Buildalyzer/Construction/ProjectFileNames.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer.Construction;
+namespace Buildalyzer.Construction;
 
 public static class ProjectFileNames
 {

src/Buildalyzer/Conversion/IOPathTypeConverter.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System.ComponentModel;
 using System.Globalization;

src/Buildalyzer/Diagnostics/CollectionDebugView.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 namespace Buildalyzer.Diagnostics;
 

src/Buildalyzer/EmptyDisposable.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 [Obsolete("Will be dropped in the next major version.")]
 public class EmptyDisposable : IDisposable

src/Buildalyzer/Environment/BuildEnvironment.cs

@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 
 namespace Buildalyzer.Environment;
 

src/Buildalyzer/Environment/DotNetInfo.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 namespace Buildalyzer.Environment;
 

src/Buildalyzer/Environment/DotNetInfoParser.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System;
 using System.IO;

src/Buildalyzer/Environment/DotNetInfoResolver.cs

@@ -1,4 +1,4 @@
-using System.Collections.Concurrent;
+using System.Collections.Concurrent;
 using Buildalyzer.IO;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Abstractions;

src/Buildalyzer/Environment/EnvironmentFactory.cs

@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 using System.Runtime.InteropServices;
 using Buildalyzer.Construction;
 using Microsoft.Build.Utilities;

src/Buildalyzer/Environment/EnvironmentOptions.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer.Environment;
+namespace Buildalyzer.Environment;
 
 public class EnvironmentOptions
 {

src/Buildalyzer/Environment/EnvironmentPreference.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer.Environment;
+namespace Buildalyzer.Environment;
 
 public enum EnvironmentPreference
 {

src/Buildalyzer/Environment/EnvironmentVariables.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer.Environment;
+namespace Buildalyzer.Environment;
 
 public static class EnvironmentVariables
 {

src/Buildalyzer/Environment/MsBuildProperties.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer.Environment;
+namespace Buildalyzer.Environment;
 
 public static class MsBuildProperties
 {

src/Buildalyzer/Extensions/CompilerLanguageExtensions.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 internal static class CompilerLanguageExtensions
 {

src/Buildalyzer/Extensions/System.Array.cs

@@ -1,4 +1,4 @@
-namespace System;
+namespace System;
 
 internal static class BuildalyzerArrayExtensions
 {

src/Buildalyzer/Extensions/System.String.cs

@@ -1,4 +1,4 @@
-namespace System;
+namespace System;
 
 internal static class BuildalyzerStringExtensions
 {

src/Buildalyzer/Guard.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System.Runtime.CompilerServices;
 

src/Buildalyzer/IAnalyzerManager.cs

@@ -1,4 +1,4 @@
-using Microsoft.Build.Construction;
+using Microsoft.Build.Construction;
 using Microsoft.Extensions.Logging;
 
 namespace Buildalyzer;

src/Buildalyzer/IAnalyzerResult.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 public interface IAnalyzerResult
 {

src/Buildalyzer/IAnalyzerResults.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 public interface IAnalyzerResults : IEnumerable<IAnalyzerResult>
 {

src/Buildalyzer/IO/IOPath.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System.ComponentModel;
 using System.IO;

src/Buildalyzer/IProjectAnalyzer.cs

@@ -1,4 +1,4 @@
-using Buildalyzer.Construction;
+using Buildalyzer.Construction;
 using Buildalyzer.Environment;
 using Microsoft.Build.Construction;
 using Microsoft.Build.Logging;

src/Buildalyzer/IProjectItem.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 public interface IProjectItem
 {

src/Buildalyzer/Logging/TextWriterLogger.cs

@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 using Microsoft.Extensions.Logging;
 
 namespace Buildalyzer.Logging;

src/Buildalyzer/Logging/TextWriterLoggerProvider.cs

@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 using Microsoft.Extensions.Logging;
 
 namespace Buildalyzer.Logging;

src/Buildalyzer/ProcessData.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 /// <summary>The data received during a <see cref="Process" />.</summary>
 [DebuggerDisplay("Output = {Output.Length}, Error = {Error.Length}")]

src/Buildalyzer/ProcessDataCollector.cs

@@ -1,4 +1,4 @@
-namespace Buildalyzer;
+namespace Buildalyzer;
 
 /// <summary>Collects the <see cref="ProcessData"/> durring a <see cref="System.Diagnostics.Process"/>.</summary>
 [DebuggerDisplay("ExitCode = {Process.ExitCode}, Output = {Process.Output.Length}, Error = {Process.Error.Length}")]

src/Buildalyzer/ProjectGuid.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System.Security.Cryptography;
 

src/Buildalyzer/ProjectItem.cs

@@ -1,4 +1,4 @@
-using Microsoft.Build.Framework;
+using Microsoft.Build.Framework;
 
 namespace Buildalyzer;
 

src/Buildalyzer/XDocumentExtensions.cs

@@ -1,4 +1,4 @@
-using System.Xml.Linq;
+using System.Xml.Linq;
 
 namespace Buildalyzer;
 

tests/Buildalyzer.Tests/Buildalyzer.Tests.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>

tests/Buildalyzer.Tests/Compiler/CompilerCommandFixture.cs

@@ -1,4 +1,4 @@
-using System.Collections.Immutable;
+using System.Collections.Immutable;
 using Buildalyzer.IO;
 using FluentAssertions;
 using FSharp.Compiler.CodeAnalysis;

tests/Buildalyzer.Tests/Construction/PackageReferenceFixture.cs

@@ -1,4 +1,4 @@
-using System.Xml.Linq;
+using System.Xml.Linq;
 using Buildalyzer.Construction;
 using Shouldly;
 

tests/Buildalyzer.Tests/Environment/DotNetInfoFixture.cs

@@ -1,4 +1,4 @@
-using Buildalyzer.Environment;
+using Buildalyzer.Environment;
 using FluentAssertions;
 
 namespace Buildalyzer.Tests.Environment;

tests/Buildalyzer.Tests/Environment/EnvironmentFactoryFixture.cs

@@ -1,4 +1,4 @@
-using Buildalyzer.Environment;
+using Buildalyzer.Environment;
 using Shouldly;
 
 namespace Buildalyzer.Tests.Environment;

tests/Buildalyzer.Tests/Environment/MsBuildPropertiesFixture.cs

@@ -1,4 +1,4 @@
-using Buildalyzer.Environment;
+using Buildalyzer.Environment;
 using FluentAssertions;
 
 namespace Buildalyzer.Tests.Environment;

tests/Buildalyzer.Tests/IO/IOPathFixture.cs

@@ -1,4 +1,4 @@
-using Buildalyzer.IO;
+using Buildalyzer.IO;
 using FluentAssertions;
 
 namespace Buildalyzer.Tests.IO;