Skip to content

Commit c7c8f65

Browse files
committed
Use RouteMiddleware instead of PathBasedRoutingMiddleware
Per changes for final v3 release.
1 parent 1caca9d commit c7c8f65

2 files changed

+13
-5
lines changed

src/OAuth2CallbackMiddlewareFactory.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
use Zend\Expressive\Authentication\AuthenticationMiddleware;
1313
use Zend\Expressive\Container\ApplicationFactory;
1414
use Zend\Expressive\Router\Middleware\DispatchMiddleware;
15-
use Zend\Expressive\Router\Middleware\PathBasedRoutingMiddleware;
15+
use Zend\Expressive\Router\Middleware\RouteMiddleware;
1616
use Zend\Expressive\Session\SessionMiddleware;
1717

1818
/**
@@ -84,7 +84,7 @@ public function __invoke(ContainerInterface $container) : MiddlewareInterface
8484
$pipeline->get($path, Debug\DebugProviderMiddleware::class);
8585
}
8686

87-
$pipeline->pipe(PathBasedRoutingMiddleware::class);
87+
$pipeline->pipe(RouteMiddleware::class);
8888
$pipeline->pipe(DispatchMiddleware::class);
8989

9090
return $pipeline;

test/OAuth2CallbackMiddlewareFactoryTest.php

+11-3
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,17 @@
1010
use Phly\Expressive\OAuth2ClientAuthentication\Debug\DebugProviderMiddleware;
1111
use Phly\Expressive\OAuth2ClientAuthentication\OAuth2CallbackMiddlewareFactory;
1212
use PHPUnit\Framework\TestCase;
13+
use Prophecy\Argument;
1314
use Prophecy\Prophecy\ObjectProphecy;
1415
use Psr\Container\ContainerInterface;
1516
use Psr\Http\Server\MiddlewareInterface;
1617
use ReflectionProperty;
1718
use Zend\Expressive\Application;
1819
use Zend\Expressive\MiddlewareContainer;
1920
use Zend\Expressive\MiddlewareFactory;
20-
use Zend\Expressive\Router\Middleware\PathBasedRoutingMiddleware;
21+
use Zend\Expressive\Router\Middleware\RouteMiddleware;
22+
use Zend\Expressive\Router\Route;
23+
use Zend\Expressive\Router\RouteCollector;
2124
use Zend\Expressive\Router\RouterInterface;
2225
use Zend\HttpHandlerRunner\RequestHandlerRunner;
2326
use Zend\Stratigility\MiddlewarePipe;
@@ -39,14 +42,19 @@ public function setUp()
3942

4043
$runner = $this->prophesize(RequestHandlerRunner::class);
4144
$router = $this->prophesize(RouterInterface::class);
42-
$routeMiddleware = new PathBasedRoutingMiddleware($router->reveal());
45+
$router->addRoute(Argument::type(Route::class))->shouldBeCalled();
46+
47+
$routeMiddleware = new RouteMiddleware($router->reveal());
48+
49+
$routes = new RouteCollector($router->reveal());
4350

4451
$this->pipeline = new MiddlewarePipe();
4552

4653
$middlewareFactory = new MiddlewareFactory(new MiddlewareContainer($this->container->reveal()));
4754
$this->container->get(MiddlewareFactory::class)->willReturn($middlewareFactory);
4855
$this->container->get(\Zend\Expressive\ApplicationPipeline::class)->willReturn($this->pipeline);
49-
$this->container->get(PathBasedRoutingMiddleware::class)->willReturn($routeMiddleware);
56+
$this->container->get(RouteCollector::class)->willReturn($routes);
57+
$this->container->get(RouteMiddleware::class)->willReturn($routeMiddleware);
5058
$this->container->get(RequestHandlerRunner::class)->will([$runner, 'reveal']);
5159

5260
$this->factory = new OAuth2CallbackMiddlewareFactory();

0 commit comments

Comments
 (0)