Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up bestNodeFor: tests #17230

Open
Ducasse opened this issue Oct 7, 2024 · 2 comments · May be fixed by #18025
Open

Cleaning up bestNodeFor: tests #17230

Ducasse opened this issue Oct 7, 2024 · 2 comments · May be fixed by #18025
Labels
Good first issue Type: Cleanup

Comments

@Ducasse
Copy link
Member

Ducasse commented Oct 7, 2024

The method

getMethodString
	^'toto
		"First comment"
		| temp variables |
		"Second comment"
		assignement := " Third comment " #node.
		"Fourth comment"
		message "Fifth comment", ''node''.
		"Sixth comment" cascade node; nodeux "Seventh comment"; notrois.
		^ "return" nil
		'

should be a valid method. This is not, then in addition it should use english (assignment and not assignement).
@saisampath2323
Copy link

@Ducasse i submitted pr which solves this issue ,kindly can you review the code and suggest any changes required
thankyou

@saisampath2323 saisampath2323 mentioned this issue Mar 19, 2025
Closed
saisampath2323 added a commit to saisampath2323/pharo that referenced this issue Mar 20, 2025
@saisampath2323
Fixes pharo-project#17230 Cleaning up bestNodeFor: tests
1aea7b9
@saisampath2323 saisampath2323 linked a pull request Mar 20, 2025 that will close this issue
Open
@Ducasse
Copy link
Member Author

Ducasse commented Mar 20, 2025

Tx I will have a look - sick last week and now super busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Type: Cleanup
Projects
None yet
Milestone
No milestone
2 participants
@Ducasse @saisampath2323