rubocop autocorrects and ignores

Author: zilchms

.rubocop.yml

@@ -1,4 +1,6 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 

.rubocop_todo.yml

@@ -0,0 +1,20 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2024-02-11 16:22:05 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 32
+# Configuration parameters: Max.
+RSpec/IndexedLet:
+  Exclude:
+    - 'spec/unit/provider/elasticsearch_component_template/ruby_spec.rb'
+    - 'spec/unit/provider/elasticsearch_ilm_policy/ruby_spec.rb'
+    - 'spec/unit/provider/elasticsearch_index/ruby_spec.rb'
+    - 'spec/unit/provider/elasticsearch_index_template/ruby_spec.rb'
+    - 'spec/unit/provider/elasticsearch_pipeline/ruby_spec.rb'
+    - 'spec/unit/provider/elasticsearch_slm_policy/ruby_spec.rb'
+    - 'spec/unit/provider/elasticsearch_snapshot_repository/ruby_spec.rb'
+    - 'spec/unit/provider/elasticsearch_template/ruby_spec.rb'

lib/puppet/type/elasticsearch_component_template.rb

@@ -48,7 +48,7 @@ def insync?(value)
               val['template']['settings']['index'] = {} unless val['template']['settings'].key? 'index'
               (val['template']['settings'].keys - ['index']).each do |setting|
                 new_key = if setting.start_with? 'index.'
-                            setting[6..-1]
+                            setting[6..]
                           else
                             setting
                           end

lib/puppet/type/elasticsearch_index_template.rb

@@ -54,7 +54,7 @@ def insync?(value)
                 val['template']['settings']['index'] = {} unless val['template']['settings'].key? 'index'
                 (val['template']['settings'].keys - ['index']).each do |setting|
                   new_key = if setting.start_with? 'index.'
-                              setting[6..-1]
+                              setting[6..]
                             else
                               setting
                             end

lib/puppet/type/elasticsearch_license.rb

@@ -31,9 +31,9 @@ def insync?(value)
     def should_to_s(newvalue)
       newvalue.transform_values do |license_data|
         if license_data.is_a? Hash
-          license_data.map do |field, value|
+          license_data.to_h do |field, value|
             [field, field == 'signature' ? '[redacted]' : value]
-          end.to_h
+          end
         else
           v
         end

lib/puppet/type/elasticsearch_template.rb

@@ -50,7 +50,7 @@
                 val['settings']['index'] = {} unless val['settings'].key? 'index'
                 (val['settings'].keys - ['index']).each do |setting|
                   new_key = if setting.start_with? 'index.'
-                              setting[6..-1]
+                              setting[6..]
                             else
                               setting
                             end

spec/spec_utilities.rb

@@ -40,7 +40,7 @@ def derive_artifact_urls_for(full_version, plugins = ['analysis-icu'])
 end
 
 def derive_full_package_url(full_version, extensions = %w[deb rpm])
-  extensions.map do |ext|
+  extensions.to_h do |ext|
     url = if full_version.start_with? '6'
             "https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-#{full_version}.#{ext}"
           elsif ext == 'deb'
@@ -49,14 +49,14 @@ def derive_full_package_url(full_version, extensions = %w[deb rpm])
             "https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-#{full_version}-x86_64.#{ext}"
           end
     [url, File.basename(url)]
-  end.to_h
+  end
 end
 
 def derive_plugin_urls_for(full_version, plugins = ['analysis-icu'])
-  plugins.map do |plugin|
+  plugins.to_h do |plugin|
     url = "https://artifacts.elastic.co/downloads/elasticsearch-plugins/#{plugin}/#{plugin}-#{full_version}.zip"
     [url, File.join('plugins', File.basename(url))]
-  end.to_h
+  end
 end
 
 def artifact(file, fixture_path = [])

spec/support/acceptance/elastic.rb

@@ -54,7 +54,7 @@
 
   v[:elasticsearch_plugins] = Dir[
     artifact("*#{v[:elasticsearch_full_version]}.zip", ['plugins'])
-  ].map do |plugin|
+  ].to_h do |plugin|
     plugin_filename = File.basename(plugin)
     plugin_name = plugin_filename.match(%r{^(?<name>.+)-#{v[:elasticsearch_full_version]}.zip})[:name]
     [
@@ -64,7 +64,7 @@
         url: derive_plugin_urls_for(v[:elasticsearch_full_version], [plugin_name]).keys.first,
       },
     ]
-  end.to_h
+  end
 
   v[:oss] = !ENV['OSS_PACKAGE'].nil? and ENV['OSS_PACKAGE'] == 'true'
   v[:cluster_name] = SecureRandom.hex(10)