Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 8606b38

Browse files
committedMar 17, 2025·
dont run aggregates over query with no aggregates
1 parent 0ab9d6a commit 8606b38

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed
 

‎pgdog/src/backend/pool/connection/buffer.rs

+10-6
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,17 @@ impl Buffer {
9595
rd: &RowDescription,
9696
) -> Result<(), super::Error> {
9797
let buffer: VecDeque<DataRow> = self.buffer.drain(0..).collect();
98-
let aggregates = Aggregates::new(&buffer, rd, aggregate);
99-
let result = aggregates.aggregate()?;
100-
101-
if !result.is_empty() {
102-
self.buffer = result;
103-
} else {
98+
if aggregate.is_empty() {
10499
self.buffer = buffer;
100+
} else {
101+
let aggregates = Aggregates::new(&buffer, rd, aggregate);
102+
let result = aggregates.aggregate()?;
103+
104+
if !result.is_empty() {
105+
self.buffer = result;
106+
} else {
107+
self.buffer = buffer;
108+
}
105109
}
106110

107111
Ok(())

0 commit comments

Comments
 (0)
Please sign in to comment.