Skip to content

Commit 718cacb

Browse files
authoredSep 16, 2024
Add logger as a dependency, drop ostruct for tests (#1010)
* Add logger as a dependency There was a warning in ruby-head (3.4) that in Ruby 3.5 logger and ostruct will not be built-in gems, but regular gems. This change avoids that warning. The ostruct dependency was be omitted. * Lint: Style/SymbolProc
1 parent 1d4cbfc commit 718cacb

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed
 

‎dalli.gemspec

+2
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,6 @@ Gem::Specification.new do |s|
2424
'changelog_uri' => 'https://github.com/petergoldstein/dalli/blob/main/CHANGELOG.md',
2525
'rubygems_mfa_required' => 'true'
2626
}
27+
28+
s.add_dependency 'logger'
2729
end

‎test/helper.rb

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
require 'dalli'
1313
require 'logger'
14-
require 'ostruct'
1514
require 'securerandom'
1615

1716
Dalli.logger = Logger.new($stdout)

‎test/integration/test_network.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
describe 'with a fake server' do
1717
it 'handle connection reset' do
18-
memcached_mock(->(sock) { sock.close }) do
18+
memcached_mock(lambda(&:close)) do
1919
dc = Dalli::Client.new('localhost:19123')
2020
assert_raises Dalli::RingError, message: 'No server available' do
2121
dc.get('abc')
@@ -25,7 +25,7 @@
2525

2626
it 'handle connection reset with unix socket' do
2727
socket_path = MemcachedMock::UNIX_SOCKET_PATH
28-
memcached_mock(->(sock) { sock.close }, :start_unix, socket_path) do
28+
memcached_mock(lambda(&:close), :start_unix, socket_path) do
2929
dc = Dalli::Client.new(socket_path)
3030
assert_raises Dalli::RingError, message: 'No server available' do
3131
dc.get('abc')

‎test/protocol/test_binary.rb

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# frozen_string_literal: true
22

3-
require 'ostruct'
43
require_relative '../helper'
54

65
describe Dalli::Protocol::Binary do

0 commit comments

Comments
 (0)