Addressed some review comments from Nathan for v1

Signed-off-by: Mohith Kumar Thummaluru <[email protected]>

Author: mohith-kumar-thummaluru

build/rpm/pcp.spec.in

@@ -1792,7 +1792,7 @@ collecting metrics from simple network checks.
 #
 %package pmda-rocestat
 License: GPL-2.0-or-later
-Summary: Performance Co-Pilot (PCP) metrics for simple network checks
+Summary: Performance Co-Pilot (PCP) metrics for nVidia RoCE devices
 URL: https://pcp.io
 Requires: pcp = @package_version@ pcp-libs = @package_version@
 %if "@enable_python3@" == "true"
@@ -1802,7 +1802,7 @@ Requires: %{__python2}-pcp
 %endif
 %description pmda-rocestat
 This package contains the PCP Performance Metrics Domain Agent (PMDA) for
-collecting statistics for RDMA over Converged Ethernet (RoCE) devices.
+collecting statistics for nVidia RDMA over Converged Ethernet (RoCE) devices.
 # end pcp-pmda-rocestat
 
 #

build/rpm/redhat.spec

@@ -1925,7 +1925,7 @@ collecting metrics from simple network checks.
 #
 %package pmda-rocestat
 License: GPL-2.0-or-later
-Summary: Performance Co-Pilot (PCP) metrics for simple network checks
+Summary: Performance Co-Pilot (PCP) metrics for nVidia RoCE devices
 URL: https://pcp.io
 Requires: pcp = %{version}-%{release} pcp-libs = %{version}-%{release}
 %if !%{disable_python3}
@@ -1935,7 +1935,7 @@ Requires: %{__python2}-pcp
 %endif
 %description pmda-rocestat
 This package contains the PCP Performance Metrics Domain Agent (PMDA) for
-collecting statistics for RDMA over Converged Ethernet (RoCE) devices.
+collecting statistics for nVidia RDMA over Converged Ethernet (RoCE) devices.
 # end pcp-pmda-rocestat
 %endif
 

src/pmdas/rocestat/domain.h

@@ -1,2 +1,2 @@
-#define ROCESTAT 257
+#define ROCESTAT 254
 

src/pmdas/rocestat/pmdarocestat.1

@@ -16,7 +16,7 @@
 .\"
 .TH PMDAROCESTAT 1 "PCP" "Performance Co-Pilot" "General Commands Manual"
 .SH NAME
-.B pdmarocestat 
+.B pmdarocestat 
 \- Performance Metrics Domain Agent (PMDA) for RoCE devices
 
 .SH DESCRIPTION

src/pmdas/rocestat/pmdarocestat.python

@@ -377,12 +377,7 @@ class MLNXCOUNTERS():
 
 class ROCESTATPMDA(PMDA):
     """
-    A ROCE Performance Metrics Domain Agent.
-    Install it and make basic use of it, as follows:
-
-    # $PCP_PMDAS_DIR/rocestat/Install
-    [select python option]
-    $ pminfo -fmdtT rocestat
+    A ROCESTAT Performance Metrics Domain Agent.
     """
 
     # Cluster definitions
@@ -397,9 +392,7 @@ class ROCESTATPMDA(PMDA):
         pm_type_32 = c_api.PM_TYPE_U32
         pm_type_64 = c_api.PM_TYPE_U64
         pm_type_double = c_api.PM_TYPE_DOUBLE
-        pm_type_str = c_api.PM_TYPE_STRING
 
-        null_indom = c_api.PM_INDOM_NULL
         inst_sem = c_api.PM_SEM_INSTANT
         count_sem = c_api.PM_SEM_COUNTER
 
@@ -595,14 +588,6 @@ class ROCESTATPMDA(PMDA):
 
         return [c_api.PM_ERR_PMID, 0]
 
-
-    def roce_store_callback(self, cluster, item, inst, val):
-        """
-        Store callback, executed when a request to write to a metric happens
-        """
-        self.log("storing values\n")
-
-
     def __init__(self, name, domain, user, logfile):
 
         super().__init__(name, domain, logfile)
@@ -615,9 +600,7 @@ class ROCESTATPMDA(PMDA):
 
         self.register_metrics(name)
         self.set_fetch(self.roce_stat_fetch)
-
         self.set_fetch_callback(self.roce_fetch_callback)
-        self.set_store_callback(self.roce_store_callback)
 
     @staticmethod
     def log(message):
@@ -636,7 +619,7 @@ if __name__ == "__main__":
     # This PMDA starts up in the "notready" state, see the Install script where
     # the IPC protocol is ipc_prot="binary notready". See also pmcd(1) man page.
     # The "binary notready" setting can also be manually configured in pmcd.conf.
-    pmda = ROCESTATPMDA(name='rocestat', domain=257, user="root", logfile='rocestat.log')
+    pmda = ROCESTATPMDA(name='rocestat', domain=254, user="root", logfile='rocestat.log')
 
     pmda.pmda_ready()
     if not pmda.in_pmda_setup():

src/pmdas/rocestat/pmns

@@ -1 +1 @@
-rocestat	257:*:*
+rocestat	254:*:*

src/pmns/stdpmid.pcp

@@ -156,11 +156,9 @@ TRIVIAL		250
 FORQA		251
 QA_TEST_PERL	252
 SIMPLE		253
-### FREE SLOT 254 ###
+ROCESTAT	254
 MEMORY_PYTHON	255
-### FREE SLOT 256 ###
-ROCESTAT	257
-### MORE FREE SLOTS 258..510 ###
+### MORE FREE SLOTS 256..510 ###
 #
 # 511 is REALLY reserved ... see DYNAMIC_PMID in libpcp.h
 #