Update cutoff_methods.R

peekxc · web-flow · commit cd7c8a75b233 · 2020-06-05T19:40:54.000-04:00
Updating cutoff to return max height value
diff --git a/R/cutoff_methods.R b/R/cutoff_methods.R
@@ -27,7 +27,8 @@ cutoff_first_bin <- function(hcl, num_bins, check_skew=TRUE) {
   if (check_skew){
     mid <- median(seq(num_bins))
     if (sum(bin_idx[1L:(mid-1L)]) < sum(bin_idx[mid:num_bins])){
-      return(as.vector(cutree(hcl, k = 1L)))
+      return(max(hcl$height))
+      # return(as.vector(cutree(hcl, k = 1L)))
     }
   }
   
@@ -68,4 +69,4 @@ cutoff_first_threshold <- function(hcl, threshold = 0.0, ...){
   return(ifelse(is.na(cut_idx) || cut_idx == 1L, max(hcl$height), f_h$x[cut_idx]))
   # if (is.na(cut_idx) || cut_idx == 1L) { as.vector(cutree(hcl, k = 1L)) }
   # else { as.vector(cutree(hcl, h = )) }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,8 @@ cutoff_first_bin <- function(hcl, num_bins, check_skew=TRUE) {`
`27`	`27`	`if (check_skew){`
`28`	`28`	`mid <- median(seq(num_bins))`
`29`	`29`	`if (sum(bin_idx[1L:(mid-1L)]) < sum(bin_idx[mid:num_bins])){`
`30`		`- return(as.vector(cutree(hcl, k = 1L)))`
	`30`	`+ return(max(hcl$height))`
	`31`	`+ # return(as.vector(cutree(hcl, k = 1L)))`
`31`	`32`	`}`
`32`	`33`	`}`
`33`	`34`
`@@ -68,4 +69,4 @@ cutoff_first_threshold <- function(hcl, threshold = 0.0, ...){`
`68`	`69`	`return(ifelse(is.na(cut_idx) \|\| cut_idx == 1L, max(hcl$height), f_h$x[cut_idx]))`
`69`	`70`	`# if (is.na(cut_idx) \|\| cut_idx == 1L) { as.vector(cutree(hcl, k = 1L)) }`
`70`	`71`	`# else { as.vector(cutree(hcl, h = )) }`
`71`		`-}`
	`72`	`+}`