-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting metadata from an mp3 stream with ReadOnlySource #349
Comments
I'll need more information to give you a definitive answer since there are some valid reasons why you may be seeing this behaviour, but it's hard to say for sure. Could you run MP3s typically store metadata in ID3v1 and ID3v2 tags. The former are located at the end of the file and thus can't be read if the source is unseekable, while the latter is at the front of the file. You sometimes also see APE tags which can be in both locations. |
This appeared in the log, in fact it's the only entry but I didn't play the whole file through. Looks like it might be relevant. I suspect storing the id3v1 tags at the end of the file means that I am asking for the impossible with a read-only source. Thanks for confirming this. I do have id3v2 tags as well as id3v1, but it looks like there is a problem with them from the log. |
I just examined the mp3 files with a hex editor and I can see the id3v2 data at the beginning. I can't be completely sure that the tags are well-formed by eye but my tag reader has no problem with them, so I'm assuming there is an issue with Symphonia. |
This shouldn't be much of an issue. It's only skipping one rarely used part of the tag.
This is more worrisome. Are you using a build from |
I'm using Symphonia-0.5.4. I can give dev-0.6 a try, not sure how much I need to change my code for the dev release as I haven't looked at it yet, it may take a while depending on the changes needed. In any case, I'll report back. I'm happy to share any file but it's probably worth trying the dev branch first. |
This is an issue for me but is really just a question as it may not be a bug.
I'm streaming an audio file and using
ReadOnlySource
. At the beginning of the stream I want to announce the artist etc, so I'm interesting in the metadata fromProbeResult
.When I stream flacs or ogg/vorbis this works fine but on mp3 files I don't get any metadata, neither from
ProbeResult.format.metadata()
nor fromProbeResult.metadata.get()
.The interesting thing is that when I use the example symphonia-play on the exact same file, now not streamed but read from the disk, the metadata is extracted and displayed correctly. The only difference that I can see is that we have a
MediaSourceStream
rather than aReadOnlySource
, at least, that's my guess.Am I asking the impossible of Symphonia here?
The text was updated successfully, but these errors were encountered: