From 7b6ed8cdef4dd2530483645666523f0b3276a184 Mon Sep 17 00:00:00 2001 From: Paul Meyer Date: Mon, 3 Jun 2019 23:07:02 +0000 Subject: [PATCH] [bug] check error on FillParameters --- builder/azure/chroot/builder.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/builder/azure/chroot/builder.go b/builder/azure/chroot/builder.go index 674e03ed039..b1b01376ea6 100644 --- a/builder/azure/chroot/builder.go +++ b/builder/azure/chroot/builder.go @@ -249,7 +249,10 @@ func (b *Builder) Run(ctx context.Context, ui packer.Ui, hook packer.Hook) (pack return nil, errors.New("the azure-chroot builder only works on Linux environments") } - b.config.ClientConfig.FillParameters() + err := b.config.ClientConfig.FillParameters() + if err != nil { + return nil, fmt.Errorf("error setting Azure client defaults: %v", err) + } azcli, err := client.New(b.config.ClientConfig, ui.Say) if err != nil { return nil, fmt.Errorf("error creating Azure client: %v", err) @@ -281,12 +284,9 @@ func (b *Builder) Run(ctx context.Context, ui packer.Ui, hook packer.Hook) (pack } state.Put("instance", info) - if err != nil { - return nil, err - } // Build the steps - steps := []multistep.Step{} + var steps []multistep.Step if b.config.FromScratch { steps = append(steps,