You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pallet-revive requires the riscv feature for benchmarks. We don't want to add it to runtime-benchmarks as that will require everybody else to have the rve toolchain installed. So we'd need a way to pass flags to the bot, however this doesn't seem to be supported currently? I imagine something like this should work: #5675 (comment)
The text was updated successfully, but these errors were encountered:
Not a problem to add, though we're going to deprecate this command bot along with old benchmarks, now we have the other command bot built as GHA, and it uses frame-omni-bencher.
I suspect this still will require riscv feature to be added in your case?
Just always enabling the riscv feature when benchmarking is good enough. That should be easier to implement than adding another command to parse. Both would work for us.
pallet-revive
requires theriscv
feature for benchmarks. We don't want to add it toruntime-benchmarks
as that will require everybody else to have the rve toolchain installed. So we'd need a way to pass flags to the bot, however this doesn't seem to be supported currently? I imagine something like this should work: #5675 (comment)The text was updated successfully, but these errors were encountered: