Skip to content

ENH: Undeprecate and reimplement DataFrame.lookup #39173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
impredicative opened this issue Jan 14, 2021 · 1 comment
Closed

ENH: Undeprecate and reimplement DataFrame.lookup #39173

impredicative opened this issue Jan 14, 2021 · 1 comment
Labels
Enhancement Needs Triage Issue that has not been reviewed by a pandas team member

Comments

@impredicative
Copy link

impredicative commented Jan 14, 2021

Is your feature request related to a problem?

I seriously get the impression that Pandas is actively being sabotaged. As a case in point, DataFrame.lookup was deprecated in v1.2.0. The problems with this are:

  1. The doc for DataFrame.lookup says to see itself for an example. Well, there is no example in the doc page. The only example I'm aware of is here instead which is a different page.
  2. The changelog for this deprecation points to GH18682 which looks to be wholly irrelevant to this change. A lot has gone wrong here.
  3. There is significant user code that already uses lookup. Why break it? If the current implementation of lookup is suboptimal, shouldn't it be optimized instead?
  4. It is extremely complicated to use melt when lookup works quite simply. For example, compare this simple answer using lookup with this complicated answer using melt.

Does nobody review changes, docs, and release notes anymore prior to release? It looks this way.

Describe the solution you'd like

  1. Undeprecate lookup.
  2. Optimize lookup if attainable using melt.
@impredicative impredicative added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 14, 2021
@impredicative
Copy link
Author

Accidental duplicate of #39171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Needs Triage Issue that has not been reviewed by a pandas team member
Projects
None yet
Development

No branches or pull requests

1 participant