-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Series.dt argument 'ambiguous' can be boolean #1178
fix: Series.dt argument 'ambiguous' can be boolean #1178
Conversation
26ac79e
to
a75cde3
Compare
Thanks for the PR. The CI is failing because |
bb23906
to
59c92b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing the __all__
thing, can you just pin pyright
to 1.1.397 in pyproject.toml
, because I just reported an issue here in pyright
: microsoft/pyright#10248
Also, can you not "force push" so then I can see what is changed with each commit more easily? |
59c92b7
to
585c942
Compare
Hi @Dr-Irv , thank you for the review and input. I force-pushed because I wanted to keep the commits clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cmp0xff
Describe the bug
In the documentation and in practice, Series.dt.floor, Series.dt.round and Series.dt.ceil accept the argument
ambiguous
as boolean, which is however not supported inpandas-stubs
.To Reproduce
Provide a minimal runnable
pandas
example that is not properly checked by the stubs.Indicate which type checker you are using (
mypy
orpyright
).mypy
Show the error message received from that type checker while checking your example.
Please complete the following information:
OS: [e.g. Windows, Linux, MacOS]
Microsoft Windows 10 Enterprise
OS Version [e.g. 22]
10.0.19045 N/A Build 19045
python version
Python 3.13.2
version of type checker
mypy==1.15.0
version of installed
pandas-stubs
pandas-stubs==2.2.3.250308
Additional context
Add any other context about the problem here.