-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analogsea::spaces doesn't return a list of spaces #214
Comments
thanks, @krose |
That would be awesome. I'm planning to build some stuff around spaces, so let me know if you need help. |
@krose Hi! Did you build some stuff around spaces? It would be great to see it |
Sadly not. I ended up doing system calls to their cli. I was under a lot of pressure to get it working fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This seems to be caused by a bug in aws.s3, but there seems to be a discussion going on if to use aws.s3 or not. The repo for aws.s3 doesn't seem to be updated with a lot of hanging pull requests, so I'll post the bug here. I hope this is fine.
There are two issues.
One concerning the
aws.s3:::parse_aws_s3_response
that checks for a content type (ctype) that doesn't match the way the API returns the xml type.The other issue is with this if statement in the spaces function:
if (identical(names(res$Buckets), c("Name", "CreationDate"))) { ... }
. In the list the names are reversed compared to the test.It seems to be two easy fixes, but the lack of development on the aws.s3 makes me hesitant to do a pull request.
The text was updated successfully, but these errors were encountered: