[ereport] index ereport ingestion by SP type/slot

Currently, the initial ereport ingestion API I added in #7833 proposed
a single dropshot API that would be implemented by both sled-agent and
MGS. This was possible because the initial design would have indexed all
ereport producers (reporters) by a UUID. However, per recent
conversations with @cbiffle and @jgallagher, we've determined that Nexus
will instead request ereports from service processors indexed by SP
physical topology (e.g. type and slot), like the rest of the MGS HTTP
API. Therefore, we can no longer have a single HTTP API for ereporters
that's implemented by both MGS and sled-agents, and instead, SP ereport
ingestion should be a new endpoint on the MGS API.

This commit does that, moving the ereport query params into
`ereport-types`, eliminating the separate `ereport-api` and
`ereport-client` crates, and adding an ereport-ingestion-by-SP-location endpoint to the management gateway API.

Author: hawkw

Diff for: Cargo.lock

@@ -14,7 +14,6 @@ members = [
     "clients/ddm-admin-client",
     "clients/dns-service-client",
     "clients/dpd-client",
-    "clients/ereport-client",
     "clients/gateway-client",
     "clients/installinator-client",
     "clients/nexus-client",
@@ -50,7 +49,6 @@ members = [
     "dns-server",
     "dns-server-api",
     "end-to-end-tests",
-    "ereport/api",
     "ereport/types",
     "gateway",
     "gateway-api",
@@ -154,7 +152,6 @@ default-members = [
     "clients/ddm-admin-client",
     "clients/dns-service-client",
     "clients/dpd-client",
-    "clients/ereport-client",
     "clients/gateway-client",
     "clients/installinator-client",
     "clients/nexus-client",
@@ -192,7 +189,6 @@ default-members = [
     "dns-server",
     "dns-server-api",
     "end-to-end-tests",
-    "ereport/api",
     "ereport/types",
     "gateway",
     "gateway-api",
@@ -393,8 +389,6 @@ dpd-client = { path = "clients/dpd-client" }
 dropshot = { version = "0.16.0", features = [ "usdt-probes" ] }
 dyn-clone = "1.0.19"
 either = "1.14.0"
-ereport-api = { path = "ereport/api" }
-ereport-client = { path = "clients/ereport-client" }
 ereport-types = { path = "ereport/types" }
 expectorate = "1.1.0"
 fatfs = "0.3.6"

Diff for: Cargo.toml

@@ -266,18 +266,6 @@ and exists as a client library within omicron. This is because the Dendrite \
 repo is not currently open source.
 """
 
-[[apis]]
-client_package_name = "ereport-client"
-label = "ereport"
-server_package_name = "ereport-api"
-versioned_how = "server"
-notes = """
-Implemented by sled-agents and by MGS, and consumed by Nexus to collect \
-ereports.
-
-The sled-agent and MGS APIs are server-versioned, so this can be as well.
-"""
-
 [[apis]]
 client_package_name = "lldpd-client"
 label = "LLDP daemon"

Diff for: clients/ereport-client/Cargo.toml

@@ -18,7 +18,6 @@ cockroach-admin-api.workspace = true
 debug-ignore.workspace = true
 dns-server-api.workspace = true
 dropshot.workspace = true
-ereport-api.workspace = true
 hex.workspace = true
 fs-err.workspace = true
 gateway-api.workspace = true

Diff for: clients/ereport-client/src/lib.rs

@@ -85,18 +85,6 @@ pub fn all_apis() -> Vec<ManagedApiConfig> {
             ident: "dns-server",
             extra_validation: None,
         },
-        ManagedApiConfig {
-            title: "Ereport Reporter API",
-            versions: Versions::new_versioned(
-                ereport_api::supported_versions()
-            ),
-            description: "API for ereport producers",
-            boundary: ApiBoundary::Internal,
-            api_description:
-                ereport_api::ereport_api_mod::stub_api_description,
-            ident: "ereport",
-            extra_validation: None,
-        },
         ManagedApiConfig {
             title: "Installinator API",
             versions: Versions::new_lockstep(semver::Version::new(0,0,1)),

Diff for: dev-tools/ls-apis/api-manifest.toml

@@ -4,12 +4,13 @@ version = "0.1.0"
 edition = "2024"
 
 [dependencies]
-omicron-uuid-kinds.workspace = true
+dropshot.workspace = true
 schemars.workspace = true
 serde.workspace = true
 serde_json.workspace = true
 uuid.workspace = true
 omicron-workspace-hack.workspace = true
+omicron-uuid-kinds.workspace = true
 
 [lints]
 workspace = true