Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge PR #105 #151

Open
floriansollami opened this issue Jan 10, 2024 · 4 comments
Open

Merge PR #105 #151

floriansollami opened this issue Jan 10, 2024 · 4 comments

Comments

@floriansollami
Copy link

floriansollami commented Jan 10, 2024 •
edited
Loading 

          @ivank, let's merge this. It'll be a step to fix https://github.com/ovotech/castle/issues/107.

After this we should update @ovotech/avro-ts dependency for @ovotech/avro-ts-cli, and bug will be fixed.

Originally posted by @gwer in #105 (comment)

Is it possible to merge this PR please ?
@floriansollami floriansollami changed the title @ivank, let's merge this. It'll be a step to fix https://github.com/ovotech/castle/issues/107. Merge PR #105 Jan 10, 2024
@floriansollami
Copy link
Author

@ivank

@floriansollami
Copy link
Author

@DamianMullins @danhawkins @pera

@gwer
Copy link

gwer commented Jan 10, 2024

For now you can try the workaround mentioned in the #107

@pera
Copy link
Member

pera commented Jan 16, 2024

@floriansollami sorry I don't work for OVO Energy (the maintainers of this project) but I've pinged a couple of folks over there so hopefully they will respond soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pera @gwer @floriansollami