Merge pull request #80 from oven-sh/ben/runloop-wakeup-no-assert

Jarred-Sumner · web-flow · commit e6cb36cabed4 · 2025-01-17T17:36:42.000-08:00
Do nothing instead of asserting `RunLoop::wakeUp` is never reached
diff --git a/Source/WTF/wtf/bun/RunLoopBun.cpp b/Source/WTF/wtf/bun/RunLoopBun.cpp
@@ -92,7 +92,8 @@ void RunLoop::stop()
 
 void RunLoop::wakeUp()
 {
-    ASSERT_NOT_REACHED();
+    // Do nothing. This means that JSRunLoopTimer::Manager::PerVMData's RunLoop::Timer leaks instead
+    // of being freed.
 }
 
 RunLoop::CycleResult RunLoop::cycle(RunLoopMode mode)

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,8 @@ void RunLoop::stop()`
`92`	`92`
`93`	`93`	`void RunLoop::wakeUp()`
`94`	`94`	`{`
`95`		`- ASSERT_NOT_REACHED();`
	`95`	`+ // Do nothing. This means that JSRunLoopTimer::Manager::PerVMData's RunLoop::Timer leaks instead`
	`96`	`+ // of being freed.`
`96`	`97`	`}`
`97`	`98`
`98`	`99`	`RunLoop::CycleResult RunLoop::cycle(RunLoopMode mode)`