Skip to content

Commit 5ebbd7b

Browse files
committed
Ensure we build webkit with debug symbols
1 parent d2b0aa2 commit 5ebbd7b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ ARG CPU=native
44
ARG LTO_FLAG="-flto=full -fwhole-program-vtables -fforce-emit-vtables "
55
ARG RELEASE_FLAGS="-O2 -DNDEBUG=1"
66
ARG LLVM_VERSION="18"
7-
ARG DEFAULT_CFLAGS="-mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -ffunction-sections -fdata-sections -faddrsig -fno-unwind-tables -fno-asynchronous-unwind-tables -DU_STATIC_IMPLEMENTATION=1 "
7+
ARG DEFAULT_CFLAGS="-mno-omit-leaf-frame-pointer -g -fno-omit-frame-pointer -ffunction-sections -fdata-sections -faddrsig -fno-unwind-tables -fno-asynchronous-unwind-tables -DU_STATIC_IMPLEMENTATION=1 "
88

99
# Use different base images for ARM64 vs x86_64
1010
FROM --platform=$BUILDPLATFORM ubuntu:20.04 as base-arm64

Dockerfile.musl

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ ARG WEBKIT_RELEASE_TYPE=Release
33
ARG CPU=native
44
ARG LTO_FLAG="-flto=full -fwhole-program-vtables -fforce-emit-vtables "
55
ARG LLVM_VERSION="18"
6-
ARG DEFAULT_CFLAGS="-mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -ffunction-sections -fdata-sections -faddrsig -fno-unwind-tables -fno-asynchronous-unwind-tables -DU_STATIC_IMPLEMENTATION=1 "
6+
ARG DEFAULT_CFLAGS="-mno-omit-leaf-frame-pointer -g -fno-omit-frame-pointer -ffunction-sections -fdata-sections -faddrsig -fno-unwind-tables -fno-asynchronous-unwind-tables -DU_STATIC_IMPLEMENTATION=1 "
77

88
FROM alpine:edge as base
99

mac-release.bash

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ cmake \
3939
-DENABLE_FTL_JIT=ON \
4040
-DCMAKE_C_COMPILER="$CMAKE_C_COMPILER" \
4141
-DCMAKE_CXX_COMPILER="$CMAKE_CXX_COMPILER" \
42-
-DCMAKE_C_FLAGS="$CMAKE_C_FLAGS -ffile-prefix-map=$THIS_DIR/Source=vendor/WebKit/Source " \
43-
-DCMAKE_CXX_FLAGS="$CMAKE_CXX_FLAGS -ffile-prefix-map=$THIS_DIR/Source=vendor/WebKit/Source " \
42+
-DCMAKE_C_FLAGS="-g $CMAKE_C_FLAGS -ffile-prefix-map=$THIS_DIR/Source=vendor/WebKit/Source" \
43+
-DCMAKE_CXX_FLAGS="-g $CMAKE_CXX_FLAGS -ffile-prefix-map=$THIS_DIR/Source=vendor/WebKit/Source" \
4444
-DENABLE_MALLOC_HEAP_BREAKDOWN=$ENABLE_MALLOC_HEAP_BREAKDOWN \
4545
-DUSE_BUN_JSC_ADDITIONS=ON \
4646
-DUSE_BUN_EVENT_LOOP=OFF \

0 commit comments

Comments
 (0)