Merge pull request #78 from oven-sh/pfg/error_stack_matching_node

Jarred-Sumner · web-flow · commit 5d0c19a6f5c5 · 2025-01-15T14:54:40.000-08:00
Match node's error.stack behaviour
diff --git a/Source/JavaScriptCore/runtime/ErrorInstance.cpp b/Source/JavaScriptCore/runtime/ErrorInstance.cpp
@@ -281,7 +281,7 @@ String ErrorInstance::sanitizedNameString(JSGlobalObject* globalObject)
     }
     RETURN_IF_EXCEPTION(scope, {});
 
-    if (!nameValue || !nameValue.isPrimitive())
+    if (!nameValue || !nameValue.isPrimitive() || nameValue.isUndefined())
         return "Error"_s;
     RELEASE_AND_RETURN(scope, nameValue.toWTFString(globalObject));
 }

Original file line number	Diff line number	Diff line change
`@@ -281,7 +281,7 @@ String ErrorInstance::sanitizedNameString(JSGlobalObject* globalObject)`
`281`	`281`	`}`
`282`	`282`	`RETURN_IF_EXCEPTION(scope, {});`
`283`	`283`
`284`		`- if (!nameValue \|\| !nameValue.isPrimitive())`
	`284`	`+ if (!nameValue \|\| !nameValue.isPrimitive() \|\| nameValue.isUndefined())`
`285`	`285`	`return "Error"_s;`
`286`	`286`	`RELEASE_AND_RETURN(scope, nameValue.toWTFString(globalObject));`
`287`	`287`	`}`