Update to vs-threading 15.8.132

sharwell · sharwell · commit 15dceadaa84f · 2018-07-22T12:15:44.000-05:00
Rules with new diagnostics are disabled.
diff --git a/Build/vs-threading.MainThreadAssertingMethods.txt b/Build/vs-threading.MainThreadAssertingMethods.txt
@@ -1 +1 @@
-GitUI.ThreadHelper.ThrowIfNotOnUIThread
+[GitUI.ThreadHelper]::ThrowIfNotOnUIThread
diff --git a/Build/vs-threading.MainThreadSwitchingMethods.txt b/Build/vs-threading.MainThreadSwitchingMethods.txt
@@ -1 +1 @@
-GitUI.ControlThreadingExtensions.SwitchToMainThreadAsync
+[GitUI.ControlThreadingExtensions]::SwitchToMainThreadAsync
diff --git a/Directory.Build.targets b/Directory.Build.targets
@@ -5,7 +5,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(EnableVisualStudioThreading)' != 'false'">
-    <PackageReference Include="Microsoft.VisualStudio.Threading" Version="15.6.46" />
+    <PackageReference Include="Microsoft.VisualStudio.Threading" Version="15.8.132" />
   </ItemGroup>
 
 </Project>
diff --git a/Externals/Git.hub b/Externals/Git.hub
@@ -1 +1 @@
-Subproject commit 8d5772c4c627168332369081fc63f4abe729aa71
+Subproject commit 7614aebab6cc57e0a2d52e8d4b675039f6719142
diff --git a/Externals/NBug b/Externals/NBug
@@ -1 +1 @@
-Subproject commit cbca134e29be13b35f21ca4553ba04f796324b1c
+Subproject commit 8b7b16675901396d6761988f86079ca99b7771cc
diff --git a/Externals/conemu-inside b/Externals/conemu-inside
@@ -1 +1 @@
-Subproject commit 67f1fdc0d0115336b2701f81737fdcd549373bd8
+Subproject commit e86c17efed310f3aa4521bad6374bc8d1f76ba97
diff --git a/GitExtUtils/GitExtUtils.csproj b/GitExtUtils/GitExtUtils.csproj
@@ -52,7 +52,6 @@
     <Compile Include="GitUI\ControlThreadingExtensions.cs" />
     <Compile Include="GitUI\DpiUtil.cs" />
     <Compile Include="GitUI\TableLayoutPanelExtensions.cs" />
-    <Compile Include="GitUI\TaskExtensions.cs" />
     <Compile Include="GitUI\ThreadHelper.cs" />
     <Compile Include="GitUI\UIExtensions.cs" />
     <Compile Include="Linq\LinqExtensions.cs" />
diff --git a/GitExtUtils/GitUI/TaskExtensions.cs b/GitExtUtils/GitUI/TaskExtensions.cs
diff --git a/GitExtensions.ruleset b/GitExtensions.ruleset
@@ -5,6 +5,12 @@
     <Rule Id="CA1301" Action="None" />
     <Rule Id="CA2101" Action="None" />
   </Rules>
+  <Rules AnalyzerId="Microsoft.VisualStudio.Threading.Analyzers" RuleNamespace="Microsoft.VisualStudio.Threading.Analyzers">
+    <Rule Id="VSTHRD004" Action="None" />
+    <Rule Id="VSTHRD010" Action="None" />
+    <Rule Id="VSTHRD109" Action="None" />
+    <Rule Id="VSTHRD110" Action="None" />
+  </Rules>
   <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
     <Rule Id="SA1101" Action="None" />
     <Rule Id="SA1116" Action="None" />
diff --git a/GitUI/UserControls/MainThreadScheduler.cs b/GitUI/UserControls/MainThreadScheduler.cs
@@ -2,6 +2,7 @@
 using System.Reactive.Concurrency;
 using System.Reactive.Disposables;
 using System.Threading.Tasks;
+using Microsoft.VisualStudio.Threading;
 
 namespace GitUI.UserControls
 {

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-GitUI.ThreadHelper.ThrowIfNotOnUIThread`
	`1`	`+[GitUI.ThreadHelper]::ThrowIfNotOnUIThread`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-GitUI.ControlThreadingExtensions.SwitchToMainThreadAsync`
	`1`	`+[GitUI.ControlThreadingExtensions]::SwitchToMainThreadAsync`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`using System.Reactive.Concurrency;`
`3`	`3`	`using System.Reactive.Disposables;`
`4`	`4`	`using System.Threading.Tasks;`
	`5`	`+using Microsoft.VisualStudio.Threading;`
`5`	`6`
`6`	`7`	`namespace GitUI.UserControls`
`7`	`8`	`{`