Revert #471 empty check

Signed-off-by: Jeff Mendoza <[email protected]>

Author: jeffmendoza

pkg/enforce/enforce.go

@@ -19,7 +19,6 @@ package enforce
 import (
 	"context"
 	"fmt"
-	"net/http"
 	"sync"
 	"time"
 
@@ -49,7 +48,6 @@ var getAppInstallationRepos func(context.Context, *github.Client) ([]*github.Rep
 var runPolicies func(context.Context, *github.Client, string, string, bool, string) (EnforceRepoResults, error)
 var deleteInstallation func(context.Context, *github.Client, int64) (*github.Response, error)
 var listInstallations func(context.Context, *github.Client) ([]*github.Installation, error)
-var isRepositoryEmpty func(context.Context, *github.Client, string, string, string) (bool, error)
 
 func init() {
 	policiesGetPolicies = policies.GetPolicies
@@ -61,7 +59,6 @@ func init() {
 	runPolicies = runPoliciesReal
 	deleteInstallation = deleteInstallationReal
 	listInstallations = listInstallationsReal
-	isRepositoryEmpty = isRepositoryEmptyReal
 }
 
 // EnforceAll iterates through all available installations and repos Allstar
@@ -321,25 +318,6 @@ func EnforceJob(ctx context.Context, ghc *ghclients.GHClients, d time.Duration,
 	}
 }
 
-// returns true if the repository has content and false if it's empty
-func isRepositoryEmptyReal(ctx context.Context, c *github.Client, owner, repo, policy string) (bool, error) {
-	opts := github.RepositoryContentGetOptions{}
-	file, dirs, resp, err := c.Repositories.GetContents(ctx, owner, repo, "", &opts)
-	if err != nil && resp.StatusCode != http.StatusNotFound {
-		return false, err
-	}
-	if file == nil && len(dirs) == 0 {
-		log.Info().
-			Str("org", owner).
-			Str("repo", repo).
-			Str("area", policy).
-			Msg("Repository is empty, skipping")
-		return true, nil
-	}
-
-	return false, nil
-}
-
 // runPoliciesReal enforces policies on the provided repo. It is meant to be called
 // from either jobs, webhooks, or delayed checks. TODO: implement concurrency
 // check to only run a single instance per repo at a time.
@@ -373,15 +351,6 @@ func runPoliciesReal(ctx context.Context, c *github.Client, owner, repo string,
 			continue
 		}
 
-		isEmpty, err := isRepositoryEmpty(ctx, c, owner, repo, p.Name())
-		if err != nil {
-			return nil, err
-		}
-
-		if isEmpty {
-			continue
-		}
-
 		r, err := p.Check(ctx, c, owner, repo)
 		if err != nil {
 			return nil, err

pkg/enforce/enforce_test.go

@@ -91,42 +91,6 @@ func (m MockGhClients) Get(i int64) (*github.Client, error) {
 
 func (m MockGhClients) LogCacheSize() {}
 
-func TestSkipEmptyRepositories(t *testing.T) {
-	policiesGetPolicies = func() []policydef.Policy {
-		return []policydef.Policy{
-			pol{},
-		}
-	}
-
-	isRepositoryEmpty = func(ctx context.Context, c *github.Client, s1, s2, s3 string) (bool, error) {
-		return true, nil
-	}
-
-	repo := "fake-repo"
-
-	tests := []struct {
-		Desc string
-	}{
-		{
-			Desc: "test skip a single empty repository",
-		},
-	}
-
-	for _, test := range tests {
-		t.Run(test.Desc, func(t *testing.T) {
-			enforceResults, err := runPoliciesReal(context.Background(), nil, "", repo, true, "")
-
-			if err != nil {
-				t.Fatalf("Unexpected error: %v", err)
-			}
-
-			if len(enforceResults) != 0 {
-				t.Errorf("expected no policy results, got %+v\n", enforceResults)
-			}
-		})
-	}
-}
-
 func TestRunPolicies(t *testing.T) {
 	policiesGetPolicies = func() []policydef.Policy {
 		return []policydef.Policy{
@@ -143,9 +107,6 @@ func TestRunPolicies(t *testing.T) {
 		closeCalled = true
 		return nil
 	}
-	isRepositoryEmpty = func(ctx context.Context, c *github.Client, s1, s2, s3 string) (bool, error) {
-		return false, nil
-	}
 	repo := "fake-repo"
 	tests := []struct {
 		Name              string