-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing Section Input Flexibility #153
Enhancing Section Input Flexibility #153
Conversation
.split(",") | ||
.map((val) => val.trim()) | ||
.filter((val) => val !== ""); | ||
const input = e.target.value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you had written a clean code for range (1-3) to work but Some edge cases is being missed make sure to check it once
@@ -257,14 +274,26 @@ const OrcaDashboardComponent = () => { | |||
}); | |||
}; | |||
|
|||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is clean and effective
start_line = term_line_num[i] if i < len(term_line_num) else None | ||
term_line_num = term_line_nums.get(term, []) | ||
|
||
for section_number in sections: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaver usage of logic and optimal lines of code really good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suprajamannava17 please check escape key , on entering the range functionality for no of sections ex : 1-3 is not working and could not able to display any error messages on failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me ! - everything is working fine
Fixes #140
What was changed?
Why was it changed?
How was it changed?