Skip to content

Commit fc60ed4

Browse files
committed
fix: notification might not pop on screen by default
1 parent 01acd4e commit fc60ed4

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

app/src/main/java/com/osfans/trime/daemon/RimeDaemon.kt

-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import android.app.PendingIntent
88
import android.content.Intent
99
import android.graphics.Color
1010
import androidx.core.app.NotificationCompat
11-
import androidx.core.app.NotificationManagerCompat
1211
import com.osfans.trime.R
1312
import com.osfans.trime.TrimeApplication
1413
import com.osfans.trime.core.Rime
@@ -124,7 +123,6 @@ object RimeDaemon {
124123
createNotificationChannel(
125124
CHANNEL_ID,
126125
appContext.getString(R.string.rime_daemon),
127-
NotificationManagerCompat.IMPORTANCE_HIGH,
128126
)
129127
TrimeApplication.getInstance().coroutineScope.launch {
130128
realRime.messageFlow.collect {

app/src/main/java/com/osfans/trime/ui/setup/SetupActivity.kt

-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import androidx.activity.enableEdgeToEdge
1212
import androidx.activity.viewModels
1313
import androidx.appcompat.app.AlertDialog
1414
import androidx.core.app.NotificationCompat
15-
import androidx.core.app.NotificationManagerCompat
1615
import androidx.core.os.bundleOf
1716
import androidx.core.view.ViewCompat
1817
import androidx.core.view.WindowInsetsCompat
@@ -117,7 +116,6 @@ class SetupActivity : FragmentActivity() {
117116
createNotificationChannel(
118117
CHANNEL_ID,
119118
appContext.getString(R.string.setup_channel),
120-
NotificationManagerCompat.IMPORTANCE_HIGH,
121119
)
122120
}
123121

app/src/main/java/com/osfans/trime/util/Notifications.kt

+3-4
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,21 @@
66
package com.osfans.trime.util
77

88
import android.app.NotificationChannel
9+
import android.app.NotificationManager
910
import android.os.Build
1011
import splitties.systemservices.notificationManager
1112

1213
fun createNotificationChannel(
1314
id: String,
1415
name: String,
15-
importance: Int,
16-
description: String? = null,
1716
) {
1817
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
1918
val channel =
2019
NotificationChannel(
2120
id,
2221
name,
23-
importance,
24-
).apply { this.description = description ?: id }
22+
NotificationManager.IMPORTANCE_HIGH,
23+
).apply { description = id }
2524
notificationManager.createNotificationChannel(channel)
2625
}
2726
}

0 commit comments

Comments
 (0)