Skip to content

Commit 4b58704

Browse files
cmwatersrootulp
andauthored
Apply suggestions from code review
Co-authored-by: Rootul P <[email protected]>
1 parent 68863fc commit 4b58704

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Diff for: pkg/inclusion/blob_share_commitment_rules.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ func BlobSharesUsedNonInteractiveDefaults(cursor, subtreeRootThreshold int, blob
5050
// fit in the square. The cursor is expected to be the index after the end of
5151
// the previous blob.
5252
//
53-
// See https://github.com/celestiaorg/go-square/blob/main/specs/src/specs/data_square_layout.md
53+
// See https://github.com/celestiaorg/celestia-app/blob/main/specs/src/specs/data_square_layout.md
5454
// for more information.
5555
func NextShareIndex(cursor, blobShareLen, subtreeRootThreshold int) int {
5656
// Calculate the subtreewidth. This is the width of the first mountain in the

Diff for: pkg/shares/sparse_shares_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func TestSparseShareSplitterCount(t *testing.T) {
8383
}
8484
}
8585

86-
// GenerateRandomBlobOfShareCount returns a blob that spans the given
86+
// generateRandomBlobOfShareCount returns a blob that spans the given
8787
// number of shares
8888
func generateRandomBlobOfShareCount(count int) *blob.Blob {
8989
size := rawBlobSize(FirstSparseShareContentSize * count)

Diff for: pkg/square/builder.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
)
1515

1616
type Builder struct {
17-
// maxSquareSize is an upper bound on the total amount of shares that could fit in the biggest square
17+
// maxSquareSize is the maximum number of rows (or columns) in the original data square
1818
maxSquareSize int
1919
// currentSize is an overestimate for the number of shares used by this builder.
2020
currentSize int

0 commit comments

Comments
 (0)