DOCKER_BUILDKIT=1 requirement

[jsonn]

While trying to run the test system, I stumbled over the need for DOCKER_BUILDKIT=1 on both Debian Bookworm and Sid. Should this be set by default by make or do I miss something else?

[polarathene]

• Docker image building minimum requirements (Recent change dropped DOCKER_BUILDKIT=1 from the Makefile):

  We make use of build features that require a recent version of Docker. v23.0 or newer is advised, but earlier releases may work.
  If you are using a version of Docker prior to v23.0, you will need to enable BuildKit via the ENV DOCKER_BUILDKIT=1

• Related

---

Should this be set by default by make or do I miss something else?

You should install Docker from official upstream (as per Dockers docs for your distro).

[jsonn]

Well, apt install docker-compose is the official Debian way for doing it and Debian is explicitly recommended in the documentation. Which makes it overall a bad UX.

[polarathene]

Which makes it overall a bad UX.

We're aligned with official Docker docs which is compose v2. So you should be using docker compose commands, not docker-compose.

We explicitly state in our docs to build the image requires v23 or newer (Feb 2023), otherwise you can try adding the ENV DOCKER_BUILDKIT=1.

---

Well, apt install docker-compose is the official Debian way for doing it and Debian is explicitly recommended in the documentation.

Tests run without compose currently, when compose is adopted it'll be expected to be v2 compatible only.

https://docs.docker.com/engine/install/debian/#installation-methods

Set up and install Docker Engine from Docker's apt repository.

https://docs.docker.com/engine/install/debian/#install-using-the-repository

Before you install Docker Engine for the first time on a new host machine, you need to set up the Docker apt repository. Afterward, you can install and update Docker from the repository.

https://docs.docker.com/engine/install/debian/#install-from-a-package

If you can't use Docker's apt repository to install Docker Engine, you can download the deb file for your release and install it manually. You need to download a new file each time you want to upgrade Docker Engine.

Compose docs also suggest the same, you perhaps misread them? I don't see any explicit "use your distro package" advice in these docs, only to add the Docker repo to your package manager and install the package from that.