Naming of options in isWithinInterval
#3709
Unanswered
sleepyArpan
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello,
In v2
isWithinInterval
used to throw an error if thestart
was after theend
. But now it doesn't matter what the dates passed are, it always checks inside the given interval. I was wondering what was the motivation behind this change? I was also wondering whether the key names forstart
andend
should change because how I am seeing it is even if thestart
provided by the user falls after theend
and we check for a date that is after theend
but beforestart
it will return true. Whereas I was expecting the function to returnfalse
since the interval provided probably is an invalid interval.Beta Was this translation helpful? Give feedback.
All reactions