Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement in the codebase of the Registry #50

Open
AayushSaini101 opened this issue Jan 23, 2025 · 1 comment
Open

Improvement in the codebase of the Registry #50

AayushSaini101 opened this issue Jan 23, 2025 · 1 comment

Comments

@AayushSaini101
Copy link
Contributor

Improvement 1: Avoid Code Duplication
Currently, in the method, there are many if conditions as well as many nested if-else condition that decrease the readability of the code.
Improvement 2: pushArtifact() can be simplified using the builder design pattern, The pushArtifact method involves assembling a Manifest object step by step
@jonesbusy I would like to work on this let me know if you have suggestion on this thanks : )
@jonesbusy
Copy link
Collaborator

Sure feel free to submit a PR if you think it improve the overall code

@AayushSaini101 AayushSaini101 mentioned this issue Jan 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonesbusy @AayushSaini101