Merge pull request #286 from opticdev/fix-popup

fix node popup node.exe on windows
opticdev · Jul 21, 2020 · 304d1c9 · 304d1c9
2 parents 783cf7f + 8fa7358
commit 304d1c9
Show file tree

Hide file tree

Showing 13 changed files with 36 additions and 33 deletions.
diff --git a/workspaces/agent-cli/package.json b/workspaces/agent-cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/agent-cli",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "author": "@useoptic",
   "bin": {
     "optic-agent": "./bin/run"
@@ -15,7 +15,7 @@
     "@oclif/command": "^1",
     "@oclif/config": "^1",
     "@oclif/plugin-help": "^3",
-    "@useoptic/cli-shared": "8.2.7",
+    "@useoptic/cli-shared": "8.2.8",
     "dotenv": "^8.2.0",
     "jwt-decode": "^2.2.0",
     "tslib": "^1",

diff --git a/workspaces/ci-cli/package.json b/workspaces/ci-cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/ci-cli",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "author": "@useoptic",
   "bin": {
     "optic-ci": "./bin/run"
@@ -15,8 +15,8 @@
     "@oclif/command": "^1",
     "@oclif/config": "^1",
     "@oclif/plugin-help": "^3",
-    "@useoptic/cli-config": "8.2.7",
-    "@useoptic/cli-shared": "8.2.7",
+    "@useoptic/cli-config": "8.2.8",
+    "@useoptic/cli-shared": "8.2.8",
     "dotenv": "^8.2.0",
     "jwt-decode": "^2.2.0",
     "tslib": "^1",

diff --git a/workspaces/cli-client/package.json b/workspaces/cli-client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/cli-client",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "scripts": {
     "ws:build": "yarn run tsc -b --verbose",
     "ws:clean": "rm -rf build/*",
@@ -14,8 +14,8 @@
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "dependencies": {
-    "@useoptic/cli-config": "8.2.7",
-    "@useoptic/client-utilities": "8.2.7",
+    "@useoptic/cli-config": "8.2.8",
+    "@useoptic/client-utilities": "8.2.8",
     "bottleneck": "^2.19.5",
     "cross-fetch": "^3.0.4"
   },

diff --git a/workspaces/cli-config/package.json b/workspaces/cli-config/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/cli-config",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "scripts": {
     "ws:test": "echo config",
     "ws:build": "yarn run tsc -b --verbose",

diff --git a/workspaces/cli-scripts/package.json b/workspaces/cli-scripts/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/cli-scripts",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "scripts": {
     "ws:test": "echo scripts",
     "ws:build": "yarn run tsc -b --verbose",
@@ -16,7 +16,7 @@
   "dependencies": {
     "node-notifier": "^7.0.0",
     "analytics-node": "^3.4.0-beta.1",
-    "@useoptic/cli-shared": "8.2.7"
+    "@useoptic/cli-shared": "8.2.8"
   },
   "devDependencies": {
     "@types/node-notifier": "^6.0.1"

diff --git a/workspaces/cli-scripts/src/index.ts b/workspaces/cli-scripts/src/index.ts
@@ -19,7 +19,10 @@ export function runManagedScript(modulePath: string, ...args: string[]) {
   const isDebuggingEnabled =
     process.env.OPTIC_DAEMON_ENABLE_DEBUGGING === 'yes';
   // const execArgv = isDebuggingEnabled ? ['--inspect=63694'] : []; // not in spawn
-  const child = cp.spawn(modulePath, args, { windowsHide: true });
+  const child = cp.spawn(process.argv0, [modulePath, ...args], {
+    windowsHide: true,
+    stdio: ['ipc'],
+  });
   return child;
 }
 

diff --git a/workspaces/cli-server/package.json b/workspaces/cli-server/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/cli-server",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "scripts": {
     "ws:build": "yarn run tsc -b --verbose",
     "ws:clean": "rm -rf build/*",
@@ -14,11 +14,11 @@
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "dependencies": {
-    "@useoptic/cli-client": "8.2.7",
-    "@useoptic/cli-config": "8.2.7",
-    "@useoptic/cli-scripts": "8.2.7",
-    "@useoptic/cli-shared": "8.2.7",
-    "@useoptic/ui": "8.2.7",
+    "@useoptic/cli-client": "8.2.8",
+    "@useoptic/cli-config": "8.2.8",
+    "@useoptic/cli-scripts": "8.2.8",
+    "@useoptic/cli-shared": "8.2.8",
+    "@useoptic/ui": "8.2.8",
     "avsc": "^5.4.18",
     "body-parser": "^1.19.0",
     "cors": "^2.8.5",

diff --git a/workspaces/cli-shared/package.json b/workspaces/cli-shared/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/cli-shared",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "scripts": {
     "ws:build": "yarn run tsc -b --verbose",
     "ws:clean": "rm -rf build/*",
@@ -15,9 +15,9 @@
   "types": "build/index.d.ts",
   "dependencies": {
     "@oclif/command": "^1.6.1",
-    "@useoptic/cli-client": "8.2.7",
-    "@useoptic/cli-config": "8.2.7",
-    "@useoptic/client-utilities": "8.2.7",
+    "@useoptic/cli-client": "8.2.8",
+    "@useoptic/cli-config": "8.2.8",
+    "@useoptic/client-utilities": "8.2.8",
     "@useoptic/domain": "10.0.3",
     "@useoptic/domain-types": "10.0.3",
     "@useoptic/domain-utilities": "10.0.3",

diff --git a/workspaces/client-utilities/package.json b/workspaces/client-utilities/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/client-utilities",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "scripts": {
     "ws:build": "yarn run tsc -b --verbose",
     "ws:clean": "rm -rf build/*",

diff --git a/workspaces/local-cli/package.json b/workspaces/local-cli/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@useoptic/cli",
   "description": "The Optic CLI",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "author": "@useoptic",
   "bin": {
     "api": "./bin/run"
@@ -16,11 +16,11 @@
     "@oclif/command": "^1",
     "@oclif/config": "^1",
     "@oclif/plugin-help": "^2",
-    "@useoptic/cli-client": "8.2.7",
-    "@useoptic/cli-config": "8.2.7",
-    "@useoptic/cli-scripts": "8.2.7",
-    "@useoptic/cli-server": "8.2.7",
-    "@useoptic/cli-shared": "8.2.7",
+    "@useoptic/cli-client": "8.2.8",
+    "@useoptic/cli-config": "8.2.8",
+    "@useoptic/cli-scripts": "8.2.8",
+    "@useoptic/cli-server": "8.2.8",
+    "@useoptic/cli-shared": "8.2.8",
     "@useoptic/domain": "10.0.3",
     "analytics-node": "^3.4.0-beta.1",
     "cli-ux": "^5.4.1",

diff --git a/workspaces/saas-types/package.json b/workspaces/saas-types/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@useoptic/saas-types",
   "description": "interfaces and types for Optic SaaS surface area",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "main": "build/index.js",
   "files": [
     "build"

diff --git a/workspaces/snapshot-tests/package.json b/workspaces/snapshot-tests/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/snapshot-tests",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "scripts": {
     "ws:build": "yarn run tsc -b --verbose",
     "ws:clean": "rm -rf build/*",

diff --git a/workspaces/ui/package.json b/workspaces/ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@useoptic/ui",
-  "version": "8.2.7",
+  "version": "8.2.8",
   "files": [
     "build",
     "index.js",
@@ -15,7 +15,7 @@
     "@material-ui/core": "^4.9.7",
     "@material-ui/icons": "^4.9.1",
     "@material-ui/lab": "^4.0.0-alpha.46",
-    "@useoptic/cli-client": "8.2.7",
+    "@useoptic/cli-client": "8.2.8",
     "@useoptic/domain": "10.0.3",
     "@useoptic/domain-utilities": "10.0.3",
     "bottleneck": "^2.19.5",