Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaxExam doesn't stop per-suite container when tests are filtered by category [PAXEXAM-901] #984

Open
ops4j-issues opened this issue Nov 9, 2017 · 0 comments
Labels

Comments

@ops4j-issues
Copy link

Dan Berindei created PAXEXAM-901

JUnit doesn't have suite listeners. ReactorManager tries to emulate them by tracking test classes for which a runner was created and calling afterSuite() on the reactor when there are 0 classes left.

This breaks down when some tests are excluded because of their categories (e.g. in Surefire using <groups/> and <excludedGroups/>). Runners are still created for the excluded tests, but then some of them are excluded in ParentRunner.filter(), and the testClasses set in ReactorManager never becomes empty.

A javadoc comment in SingletonStageReactor says "The teardown logic is postponed to a JVM shutdown hook.", but I haven't found that shutdown hook.

In our POM we filter tests by category so that we can run the reactor-per-suite tests in one JVM and the reactor-per-class/reactor-per-method tests in another JVM (as a workaround for PAXEXAM-639 ).


Affects: 4.11.0
Votes: 0, Watches: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant