Skip to content

check-member-data: Try member URLs multiple times before failing #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladh opened this issue Feb 28, 2025 · 4 comments · Fixed by #356 or #384
Closed

check-member-data: Try member URLs multiple times before failing #354

vladh opened this issue Feb 28, 2025 · 4 comments · Fixed by #356 or #384
Assignees

Comments

@vladh
Copy link
Member

vladh commented Feb 28, 2025

Disabling the workflow until this is done.

@vladh
Copy link
Member Author

vladh commented Mar 3, 2025

Clearly this is not done:

#363

Okay, yeah, I don't know, this is weird. Is GitHub just 404ing repeatedly for no reason? Do we need a huge timeout? If only these actions were introspectable like on Sourcehut. :\

@vladh
Copy link
Member Author

vladh commented Mar 4, 2025

This is what is happening currently, with a 2000ms sleep between GET requests:

Creating exception issue: “Platformatic: member URL not retrievable”
GET https://blog.platformatic.dev/platformatic-joins-the-open-source-pledge
GET https://blog.platformatic.dev/platformatic-joins-the-open-source-pledge
GET https://blog.platformatic.dev/platformatic-joins-the-open-source-pledge
GET https://blog.platformatic.dev/platformatic-joins-the-open-source-pledge
GET https://blog.platformatic.dev/platformatic-joins-the-open-source-pledge

But on my end, this URL is clearly accessible. Not sure what to do here, let's see. Maybe a huge timeout. Maybe printing out the nature of the network error, which would give us something to report to GitHub if it's a GitHub network issue.

@vladh
Copy link
Member Author

vladh commented Mar 18, 2025

This is a Vercel-related issue.

  [Symbol(Response internals)]: {
    type: 'default',
    url: 'https://blog.pixee.ai/pixees-pledge-to-open-source',
    status: 429,
    statusText: 'Too Many Requests',
    headers: {
      'cache-control': 'private, no-store, max-age=0',
      'content-type': 'text/html; charset=utf-8',
      date: 'Tue, 18 Mar 2025 15:16:46 GMT',
      server: 'Vercel',
      'x-vercel-challenge-token': '2.1742311006.60.YzE5OTcxNDk5MDcwY2RhYmQ1MDY3ZDM2NzY3NTM3ZGQ7MDU5ZWJiNGE7MjU4NzI5NDM5MDA2NWNjNDk4ZmYyNDE4Zjk4ODAzMDUzNDQ2MDUyZDszO3RRZPvfW12Igx8ugh2G/wmp28ltsaujzN9ArNc=.11f2767dffc2503ecc41a56d9efe2e41',
      'x-vercel-mitigated': 'challenge'
    },
    counter: 0,
    highWaterMark: 16384
  }
   [Symbol(Response internals)]: {
    type: 'default',
    url: 'https://blog.platformatic.dev/platformatic-joins-the-open-source-pledge',
    status: 429,
    statusText: 'Too Many Requests',
    headers: {
      'cache-control': 'private, no-store, max-age=0',
      'content-type': 'text/html; charset=utf-8',
      date: 'Tue, 18 Mar 2025 15:16:49 GMT',
      server: 'Vercel',
      'x-vercel-challenge-token': '2.1742311009.60.NDBhNDg5YTdlMTllMjM2OWZkZmRhN2M2MTQwNDNkNmI7Yjc5MmY4ZWQ7Yjk0NzY2ZWU4OGFiNDI3MjU4MWEwYWZmMzcxMmNhZGNjYzc2NDgwYzszO0Hr4f2vKk9iL58rrfojBYyaQydAa+k/wSTEwjM=.f80bb436d472c3a6d5c40903d45dfa63',
      'x-vercel-mitigated': 'challenge'
    },
    counter: 0,
    highWaterMark: 16384
  }

@vladh
Copy link
Member Author

vladh commented Mar 18, 2025

It looks like what's happening is that other GitHub users are using Actions to make requests to Vercel websites, and Vercel is throttling one or multiple GitHub runner IPs. There's no real way around this aside from moving off of Actions, so I've added some code that checks if we got a 429 response, and if so, just skips that particular check. This means that we won't be able to verify URLs for Pixee and Platformatic. 🤷🏻

Implemented in #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant