Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New HTML report of CTL test suites: Inherited failures are not marked but counted as usual failures #331

Closed
dstenger opened this issue Apr 16, 2018 · 5 comments · Fixed by #353
Closed

New HTML report of CTL test suites: Inherited failures are not marked but counted as usual failures #331

dstenger opened this issue Apr 16, 2018 · 5 comments · Fixed by #353
Assignees
@dstenger @lgoltz
Labels
enhancement
Milestone
5.4

Comments

@dstenger
Copy link
Contributor

Inherited failures are not marked but counted as usual failures.

Extracted from: #319 (comment)
@dstenger
Copy link
Contributor Author

Currently, the new test report does not contain the result type inherited failure.

My proposal to prevent confusion is to ignore inherited failures in the new report. Otherwise, a single test failure can lead to more than one counted failure which can confuse users.

@dstenger dstenger mentioned this issue Apr 16, 2018
Closed
@dstenger
Copy link
Contributor Author

Proposal shall be implemented.

@keshavnangare
Copy link
Contributor

Updated the new HTML report and ignored the inheritedFailure test counting from the failure. Also changed the background color of the INHERITEDFAILURE test. We can see in screenshot the gray color represents the inherited failure tests.

image

@keshavnangare keshavnangare mentioned this issue Jul 25, 2018
Merged
@dstenger
Copy link
Contributor Author

dstenger commented Jul 31, 2018 •
edited
Loading

I propose following changes:

  • Mark inherited failures with bright red.
  • If there are any inherited failures, add following column to report (right below name of conformance class and to the right of "Fail" column).
    • Inherited fail:
    • This new column contains count of all inherited failures.
    • Color of new column is also bright red.
    • Column shall just appear if there are any inherited failures.
    • "Total tests" must contain the sum of Pass + Fail + Inherited fail + Skip.

@keshavnangare
Copy link
Contributor

Updated the new HTML report according to the proposal.

inheritedfail_new_column
newhtmlreport

@dstenger

Can you please review this changes?

@dstenger dstenger assigned dstenger and lgoltz and unassigned keshavnangare Aug 29, 2018
lgoltz added a commit that referenced this issue Apr 23, 2019
@lgoltz
#331 - changed background color of inherited failures
c9b2967
@lgoltz lgoltz added this to the 5.4 milestone Apr 23, 2019
@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to Done in CITE Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dstenger dstenger

@lgoltz lgoltz

Labels
enhancement
Projects
CITE
Archived in project
Milestone
5.4
Development

Successfully merging a pull request may close this issue.

Ignored inherited failure count to avoid confusion of user. opengeospatial/teamengine
3 participants
@dstenger @lgoltz @keshavnangare