Skip to content

Commit 777a770

Browse files
committed
Update readme
1 parent 27204f8 commit 777a770

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

README.md

+11-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,17 @@ There is also a few method that refers to this attribute, such as:
5757
- \Magento\Catalog\Model\ResourceModel\Product\Collection::joinMinimalPrice (Never called)
5858

5959
This attribute and methods are not used in the Commerce edition neither.
60-
This module updates and reuse this existing attribute in order to give it a true usage.
60+
This module updates and reuse this existing attribute in order to give it a true usage.
61+
62+
Also, while investigating a bug where the minimal price value was not handled in the PDP nor PLP.
63+
It seems that the catalog_product_index_price is not used to render and display the final prices.
64+
When inspecting the query logs, it seems that even if the indexer is loaded and applied to the product list,
65+
when the template render the prices, the following method is used `\Magento\Catalog\Block\Product\ListProduct::getProductPrice`.
66+
This method calls `Magento\Framework\Pricing\Render::render` which render a price by code. The engine will proceed with
67+
`Magento\Catalog\Pricing\Price\FinalPrice` and `Magento\Catalog\Pricing\Price\BasePrice`. The rendering is finally delegated
68+
to `Magento\CatalogRule\Pricing\Price\CatalogRulePrice` which loads any active catalog rules.
69+
70+
The performance struggles comes when you have a lot of active catalog rule loaded every team for each items on the page.
6171

6272
## Support
6373

0 commit comments

Comments
 (0)