Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lvm-localpv lvmPlugin does not support loglevel #300

Open
ferhatguneri opened this issue May 7, 2024 · 2 comments
Open

lvm-localpv lvmPlugin does not support loglevel #300

ferhatguneri opened this issue May 7, 2024 · 2 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature milestone/needs-tracking Indicates that an issue or PR needs to be tracked on a milestone

Comments

@ferhatguneri
Copy link

openebs-lvm-plugin container does not support loglevel.

What did you expect to happen:
openebs-lvm-localpv-controller and openebs-lvm-localpv-node does support and loglevel can be defined for them but sidecar container of controller which is openebs-lvm-plugin does not support --v=3 parameter.

Log Level can be configured for lvmNode and lvmController
https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/values.yaml#L56
https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/values.yaml#L73

But it cannot be configured for lvmPlugin. and I tried to pass --v=3 to the sidecard container just like the others but, it crashed the container.
https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/values.yaml#L145

Environment:

  • openebs helm chart version 3.10.0
  • v1.27.8
  • Linux
@dsharma-dc dsharma-dc added kind/improvement Categorizes issue or PR as related to improving upon a current feature milestone/needs-tracking Indicates that an issue or PR needs to be tracked on a milestone and removed kind/improvement Categorizes issue or PR as related to improving upon a current feature labels Jun 6, 2024
@avishnu avishnu added the kind/feature Categorizes issue or PR as related to a new feature label Sep 19, 2024
@avishnu
Copy link
Member

avishnu commented Sep 19, 2024

Further investigation is needed, scoped for v4.3.

@avishnu avishnu added this to the v4.3 milestone Sep 19, 2024
@avishnu avishnu removed this from the v4.3 milestone Jan 8, 2025
@avishnu avishnu added this to the LocalPV-LVM v1.7 milestone Feb 6, 2025
@niladrih
Copy link
Member

niladrih commented Feb 6, 2025

Hi @ferhatguneri, just noticed this one. lvmPlugin is not an individual component (different from the lvmController and the lvmNode). The components lvmController and lvmNode use the same container image. The lvmPlugin bit carries the configuration for the options which are native to the container image (which is the same for the two components lvmController and lvmNode). You'd get logLevel 3 for all of the components if you set the value for the lvmController and the lvmNode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature milestone/needs-tracking Indicates that an issue or PR needs to be tracked on a milestone
Projects
Status: No status
Development

No branches or pull requests

4 participants